Skip to content

PHP 8.4 has deprecated warnings #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

PHP 8.4 has deprecated warnings #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Liip/RMT/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function __construct()
/**
* {@inheritdoc}
*/
public function run(InputInterface $input = null, OutputInterface $output = null): int
public function run(?InputInterface $input = null, ?OutputInterface $output = null): int
{
return parent::run($input, new Output());
}
Expand Down
6 changes: 3 additions & 3 deletions src/Liip/RMT/Output/Output.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Output extends ConsoleOutput
/** @var DialogHelper|QuestionHelper */
protected $dialogHelper = null;

public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, OutputFormatterInterface $formatter = null)
public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, ?OutputFormatterInterface $formatter = null)
{
// Use our own formatter
parent::__construct($verbosity, $decorated, $formatter);
Expand Down Expand Up @@ -115,7 +115,7 @@ public function writeEmptyLine($repeat = 1)

// when we drop symfony 2.3 support, we should switch to the new QuestionHelper (since 2.5) and see if we need these methods at all anymore
// QuestionHelper does about the same as we do here.
public function askQuestion(InteractiveQuestion $question, $position = null, InputInterface $input = null)
public function askQuestion(InteractiveQuestion $question, $position = null, ?InputInterface $input = null)
{
$text = ($position !== null ? $position .') ' : null) . $question->getFormatedText();

Expand Down Expand Up @@ -145,7 +145,7 @@ public function askQuestion(InteractiveQuestion $question, $position = null, Inp
}

// when we drop symfony 2.3 support, we should switch to the QuestionHelper (since 2.5) and drop this method as it adds no value
public function askConfirmation($text, InputInterface $input = null)
public function askConfirmation($text, ?InputInterface $input = null)
{
if ($this->dialogHelper instanceof QuestionHelper) {
if (!$input) {
Expand Down