Skip to content

Conversation

@pmlt
Copy link

@pmlt pmlt commented Feb 14, 2014

Removed the proxy actor of WebsocketFrontend by overriding
HttpServerConnection instead in SocketListener.

Removed the proxy actor of WebsocketFrontend by overriding
HttpServerConnection instead in SocketListener.
@lihaoyi
Copy link
Owner

lihaoyi commented Feb 16, 2014

Thanks for the patch! One question: the style of having separate actors was monkeyed blindly from the spray HTTP stack. Does that stack suffer the same problem? Or does it work around it in another way? Just want to get some context around the issue.

@pmlt
Copy link
Author

pmlt commented Feb 16, 2014

Well, I haven't tested a pure Spray Can app to see if it exhibits the same problem, so maybe it does. But in principle, having a proxy actor isn't the problem itself; it's the fact that not all TCP event messages were proxied by the same actor. Technically, even with my patch SprayWebSockets still uses a proxy actor similar to Spray Can (namely SocketServerConnection) but at least now all TCP event messages go through that proxy actor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants