-
Notifications
You must be signed in to change notification settings - Fork 49
improved readiness probe #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
315d68a to
faffab6
Compare
faffab6 to
fffbd73
Compare
| try: | ||
| from models.config import ServiceConfiguration | ||
| diagnostic_port = int(os.getenv("DIAGNOSTIC_PORT", "8090")) | ||
| start_diagnostic_uvicorn(ServiceConfiguration(host="0.0.0.0", port=diagnostic_port)) |
Check warning
Code scanning / Bandit
Possible binding to all interfaces. Warning
| try: | ||
| from models.config import ServiceConfiguration | ||
| diagnostic_port = int(os.getenv("DIAGNOSTIC_PORT", "8090")) | ||
| start_diagnostic_uvicorn(ServiceConfiguration(host="0.0.0.0", port=diagnostic_port)) |
Check warning
Code scanning / Bandit
Possible binding to all interfaces. Warning
fffbd73 to
ce62fb8
Compare
Description
Current readiness probe couldn't detect configuration loading failures due to unresolved environment variables, because the application crashed before the probe endpoint was available. Also there were no validation of template placeholder resolution and no comprehensive application initialization tracking.
Enhanced readiness probe detects unresolved template placeholders using generic pattern matching, monitors initialization steps (config loading, llama client, MCP servers, etc.) while maintaining existing LLM provider health functionality. It also returns detailed reason in readiness probe response for troubleshooting.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Tested by building and running local assisted-chat stack.
Readiness probe response when using bad config: (HTTP 503 Service Unavailable)
Same with proper config: