-
Notifications
You must be signed in to change notification settings - Fork 49
LCORE-248: regenerated OpenAPI schema #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe OpenAPI documentation and schema were updated to add an optional boolean property, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/openapi.json (1)
1446-1457: Add an explicitdescriptionfor the new property.The newly-introduced
no_toolsproperty hastitleanddefault, but lacks adescriptionat the field level. Including it improves generated client SDKs and keeps the style consistent with other optional fields (e.g.attachments,system_prompt) that also omit a description, but for a user-facing flag the intent is worth documenting locally."no_tools": { + "description": "If true, bypass all tools and configured MCP servers.", "anyOf": [ { "type": "boolean" }, { "type": "null" } ], "title": "No Tools", "default": false },docs/openapi.md (1)
730-747: Specify the field type in the table forno_tools.The “Type” column is empty for the newly-added row, while other boolean fields (e.g.
disable_query_system_prompt,auth_enabled) leave this blank as well, but addingbooleanhelps readers scanning the table.-| no_tools | | | +| no_tools | boolean | |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/openapi.json(3 hunks)docs/openapi.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e_tests
🔇 Additional comments (2)
docs/openapi.json (2)
1476-1484: Model-level description update looks good.Nice job updating the docstring to mention
no_tools; this keeps the generated schema self-contained and clear.
1498-1499: Example kept in sync – LGTMThe example payload now contains
"no_tools": false, mirroring the new default. ✅
Description
LCORE-248: regenerated OpenAPI schema
Type of change
Related Tickets & Documents
Summary by CodeRabbit
no_tools, for theQueryRequestmodel. This attribute allows users to indicate whether to bypass all tools and MCP servers.