Skip to content

proof: expand validation logging for inclusion/exclusion proofs #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

proof: expand validation logging for inclusion/exclusion proofs #1866

wants to merge 3 commits into from

Conversation

@ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 4, 2025

Enhance proof validation logging to surface both invalid and missing inclusion/exclusion proofs.

Changes:

  • Log p2tr output indexes of inclusion proofs that are invalid or absent.

@ffranr ffranr self-assigned this Nov 4, 2025
@coveralls
Copy link

coveralls commented Nov 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 19102093572

Details

  • 13 of 33 (39.39%) changed or added relevant lines in 3 files are covered.
  • 30 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+6.9%) to 56.428%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tapgarden/caretaker.go 0 1 0.0%
proof/verifier.go 3 22 13.64%
Files with Coverage Reduction New Missed Lines %
tapdb/assets_common.go 2 78.34%
tapdb/mssmt.go 2 91.36%
mssmt/compacted_tree.go 4 78.57%
tapdb/universe.go 4 81.27%
rfq/order.go 18 58.1%
Totals Coverage Status
Change from base Build 19031786416: 6.9%
Covered Lines: 63991
Relevant Lines: 113403
💛 - Coveralls

ffranr added 2 commits November 5, 2025 11:14
@ffranr
proof: add asset ID to error message
a93ff2a
@ffranr
tapgarden+universe: improve logging/error messages for uni proof insert
7f7c8ce 
Enhanced clarity and detail in log and error messages during the
insertion of proofs into the universe. This aids in debugging and
provides better feedback during failures or unexpected states.
@ffranr ffranr marked this pull request as ready for review November 5, 2025 12:32
@ffranr ffranr requested review from darioAnongba and jtobin November 5, 2025 14:46
jtobin
jtobin approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like a custom channels flake in CI.

@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtobin jtobin jtobin approved these changes

@darioAnongba darioAnongba Awaiting requested review from darioAnongba

At least 2 approving reviews are required to merge this pull request.

Assignees

@ffranr ffranr

Labels

no-changelog proofs validation

Projects

Taproot-Assets Project Board
Status: 👀 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ffranr @coveralls @jtobin