Skip to content

AddrReceives pagination and sorting direction #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 1, 2025
Merged

AddrReceives pagination and sorting direction #1813

merged 25 commits into from
Oct 1, 2025

Conversation

darioAnongba
Copy link
Contributor

This PR enables pagination for AddrReceives endpoint.

Fixes #728

Roasbeef and others added 2 commits September 9, 2025 19:44
@Roasbeef
docs: add docs on e2e RFQ arch
ec5dabd
@jtobin
docs: fix up section titles in rfq arch doc
b7172c9 
A stylistic tagline had been appended to several section titles, which
felt out of place to me. This commit removes all such taglines, and also
renames the 'The Architecture of Precision' section to 'The FixedPoint
Type' (which is what it primarily deals with).
@darioAnongba darioAnongba self-assigned this Sep 23, 2025
@darioAnongba darioAnongba marked this pull request as ready for review September 23, 2025 11:34
@darioAnongba darioAnongba requested review from GeorgeTsagk and ffranr and removed request for GeorgeTsagk September 23, 2025 11:37
@coveralls
Copy link

coveralls commented Sep 23, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18163847987

Details

  • 37 of 87 (42.53%) changed or added relevant lines in 8 files are covered.
  • 25 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+6.9%) to 56.548%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 16 22 72.73%
cmd/commands/addrs.go 0 7 0.0%
taprpc/universerpc/universe.pb.go 1 10 10.0%
taprpc/taprootassets.pb.go 4 15 26.67%
taprpc/tapcommon.pb.go 5 22 22.73%
Files with Coverage Reduction New Missed Lines %
tapdb/addrs.go 2 76.62%
tapdb/assets_common.go 2 78.34%
tapdb/sqlc/transfers.sql.go 2 83.33%
universe/supplyverifier/manager.go 2 64.53%
rpcserver.go 4 61.32%
tapdb/universe.go 6 80.81%
tapdb/assets_store.go 7 79.61%
Totals Coverage Status
Change from base Build 18145713853: 6.9%
Covered Lines: 63850
Relevant Lines: 112913
💛 - Coveralls

jtobin
jtobin reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple of questions around instituting a max pagination limit & some minor refactoring.

@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch 2 times, most recently from 87cbb20 to 5424183 Compare September 25, 2025 10:29
jtobin
jtobin approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 👍

ffranr
ffranr reviewed Sep 25, 2025
View reviewed changes
@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Sep 25, 2025
@levmi levmi added this to the v0.8 milestone Sep 25, 2025
@darioAnongba darioAnongba removed the request for review from GeorgeTsagk September 25, 2025 16:07
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch 2 times, most recently from 2a82a5c to 23687a2 Compare September 26, 2025 11:28
@darioAnongba darioAnongba requested a review from ffranr September 26, 2025 12:06
ffranr
ffranr reviewed Sep 26, 2025
View reviewed changes
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch 3 times, most recently from cca3ee1 to d0a6db1 Compare September 26, 2025 15:35
@darioAnongba darioAnongba requested a review from ffranr September 26, 2025 16:11
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch from d0a6db1 to f23f5ce Compare September 30, 2025 14:25
@darioAnongba darioAnongba removed the request for review from ffranr September 30, 2025 14:36
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch from f23f5ce to df205fd Compare September 30, 2025 15:07
@Roasbeef
Merge pull request #1820 from lightninglabs/wip/supplyverify/late-min…
df6ae3f 
…t-precommit-sync

Extract supply pre-commits from mint leaves during supply verifier sync
@Roasbeef
docs: remove old accidentally committed asset funding doc
26ec664
@Roasbeef
docs: add docs that detail the asset chan funding process
956c4df 
In this commit, we add some additional docs that explain how asset
channels differ from normal channels, and some of the interaction that
happens with `lnd` using the set of relevant `Aux*` interfaces that
`tapd` implements.
@Roasbeef
Merge pull request #1783 from Roasbeef/asset-funding-docs
88de56a 
docs: add docs that detail the asset chan funding process
@Roasbeef
Merge pull request #1787 from Roasbeef/rfq-multi-repo-docs
614acdc 
docs: add docs on e2e RFQ arch
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch from 5a5483a to 8af7179 Compare October 1, 2025 09:56
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch from 8af7179 to d65d536 Compare October 1, 2025 09:58
@darioAnongba darioAnongba requested a review from ffranr October 1, 2025 10:00
@darioAnongba darioAnongba added addrs enhancement New feature or request receive and removed enhancement New feature or request labels Oct 1, 2025
@darioAnongba darioAnongba force-pushed the feat/addr-receives-pagination branch from d65d536 to b4bba57 Compare October 1, 2025 13:31
ffranr
ffranr approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ffranr ffranr added this pull request to the merge queue Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@ffranr ffranr added this pull request to the merge queue Oct 1, 2025
@ffranr ffranr removed this pull request from the merge queue due to a manual request Oct 1, 2025
@ffranr
Copy link
Contributor

ffranr commented Oct 1, 2025

Do we merge this into 0-8-0-staging given the milestone? If so, we need to change the base branch.

@darioAnongba
Copy link
Contributor Author

It was decided to merge this into 0.7 as far as I understood.

@darioAnongba darioAnongba changed the base branch from main to 0-8-0-staging October 1, 2025 15:10
@darioAnongba darioAnongba merged commit e77362a into 0-8-0-staging Oct 1, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Oct 1, 2025
@Roasbeef Roasbeef mentioned this pull request Oct 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtobin jtobin jtobin approved these changes

@ffranr ffranr ffranr approved these changes

Assignees

@darioAnongba darioAnongba

Labels
addrs receive
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

[feature]: pagination for AddrReceives
6 participants
@darioAnongba @coveralls @ffranr @jtobin @levmi @Roasbeef