Skip to content

Conversation

Sanket-Kurle
Copy link
Contributor

I updated tv_screen.dart to properly configure the chessboard in spectator mode.
Added interactiveBoardParams with PlayerSide.none
Screenshot 2025-09-18 at 8 23 10 PM

this is solution for issue #2128

@Sanket-Kurle
Copy link
Contributor Author

@veloce
sorry for tagging but will you please check it once
actually quite desperate as its my first Open Source contribution

@HaonRekcef
Copy link
Contributor

@Sanket-Kurle Veloce is currently on holiday, he will review this PR in due time.

@Sanket-Kurle
Copy link
Contributor Author

okay 👍

@Sanket-Kurle
Copy link
Contributor Author

@HaonRekcef have you seen these changes
are they same as you suggested

@HaonRekcef
Copy link
Contributor

Yes looks good to me thanks! Did you test them in a real game as a spectator?

@Sanket-Kurle
Copy link
Contributor Author

not in real game
i have some queries to that
can we connect on personal thread on any other social media

@HaonRekcef
Copy link
Contributor

HaonRekcef commented Sep 20, 2025

You can write me on lichess: https://lichess.org/@/nfchess13

@veloce
Copy link
Contributor

veloce commented Sep 21, 2025

I see the changes. I don't understand the Spectator Check Demo screenshot though. It does not come from the app, it is not really useful then.

@veloce
Copy link
Contributor

veloce commented Sep 21, 2025

I don't really like passing interactiveBoard params to a board that is not supposed to be interactive. To me the missing check highlight in the TV is not a big deal in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants