Skip to content

Give 15 seconds over the board. #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Give 15 seconds over the board. #1885

wants to merge 3 commits into from

Conversation

dl8sd11
Copy link

@dl8sd11 dl8sd11 commented Jun 15, 2025

veloce
veloce reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I'll merge it when missing checks are added.

lib/src/model/over_the_board/over_the_board_clock.dart
}

void giveTime(Duration amount) {
final newTime = state.timeLeft(state.activeClock!)! + amount;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the clock can be disabled in which case this method would crash. You should check for that first.

lib/src/view/over_the_board/over_the_board_screen.dart
);
},
),
BottomSheetAction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no clock this button should be hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloce veloce veloce left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dl8sd11 @veloce