fix: skip muxer negotiation #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skips early muxer negotiation during noise handshake since WebRTC incorporates it's own muxer. Fixes an edge case where a node is only configured with the WebRTC-Direct transport and no additional muxers.
maschad
reviewed
Apr 16, 2025
There was a problem hiding this comment.
The https://github.com/ipshipyard/roadmaps/issues/22 is broken but based on ChainSafe/js-libp2p-noise#519 this makes sense.
Question wouldn't this also apply to webtransport as well since it uses TLS?
Nevermind I just saw #3081 was merged 😅
maschad
approved these changes
Apr 16, 2025
It's a tracking issue for maintenance & stewardship work done on js-libp2p to help with future funding requests from the libp2p foundation. @cewood tells me it's going to be made public at some point in the near future. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips early muxer negotiation during noise handshake since WebRTC incorporates it's own muxer.
Fixes an edge case where a node is only configured with the WebRTC-Direct transport and no additional muxers.
Refs: ChainSafe/js-libp2p-noise#519
Refs: https://github.com/ipshipyard/roadmaps/issues/22
Change checklist