feat: add support initial peerstore support #14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* eslint-env mocha */ | ||
| /* eslint max-nested-callbacks: ['error', 5] */ | ||
| 'use strict' | ||
|
|
||
| const chai = require('chai') | ||
| chai.use(require('dirty-chai')) | ||
| const expect = chai.expect | ||
| const os = require('os') | ||
| const path = require('path') | ||
| const ma = require('multiaddr') | ||
| const { createDaemon } = require('../../src/daemon') | ||
| const Client = require('../../src/client') | ||
| const { createLibp2p } = require('../../src/libp2p') | ||
| const { isWindows } = require('../../src/util') | ||
| const { connect } = require('../util') | ||
| const { | ||
| Request, | ||
| Response, | ||
| PeerstoreRequest | ||
| } = require('../../src/protocol') | ||
|
|
||
| const daemonAddr = isWindows | ||
| ? ma('/ip4/0.0.0.0/tcp/8080') | ||
| : ma(`/unix${path.resolve(os.tmpdir(), '/tmp/p2pd.sock')}`) | ||
|
|
||
| describe('peerstore features', () => { | ||
| let daemon | ||
| let libp2pPeer | ||
| let client | ||
|
|
||
| before(async function () { | ||
| // this.timeout(20e3) | ||
| daemon = await createDaemon({ | ||
| quiet: false, | ||
| q: false, | ||
| bootstrap: false, | ||
| hostAddrs: '/ip4/0.0.0.0/tcp/0,/ip4/0.0.0.0/tcp/0/ws', | ||
| b: false, | ||
| dht: true, | ||
| dhtClient: false, | ||
| connMgr: false, | ||
| listen: daemonAddr.toString(), | ||
| id: '', | ||
| bootstrapPeers: '' | ||
| }) | ||
| libp2pPeer = await createLibp2p({ | ||
| dht: true, | ||
| hostAddrs: '/ip4/0.0.0.0/tcp/0' | ||
| }) | ||
|
|
||
| await Promise.all([ | ||
| daemon.start(), | ||
| libp2pPeer.start() | ||
| ]) | ||
|
|
||
| await connect({ | ||
| libp2pPeer, | ||
| multiaddr: daemonAddr | ||
| }) | ||
| }) | ||
|
|
||
| before(async () => { | ||
| await new Promise(resolve => setTimeout(resolve, 1e3)) | ||
| }) | ||
|
|
||
| after(() => { | ||
| return Promise.all([ | ||
| daemon.stop(), | ||
| libp2pPeer.stop() | ||
| ]) | ||
| }) | ||
|
|
||
| afterEach(async () => { | ||
| await client && client.close() | ||
| }) | ||
|
|
||
| it('should be able to get the protocols for a peer', async () => { | ||
| client = new Client(daemonAddr) | ||
|
|
||
| await client.attach() | ||
|
|
||
| const request = { | ||
| type: Request.Type.PEERSTORE, | ||
| peerStore: { | ||
| type: PeerstoreRequest.Type.GET_PROTOCOLS, | ||
| id: Buffer.from(libp2pPeer.peerInfo.id.toBytes()) | ||
| } | ||
| } | ||
|
|
||
| const stream = client.send(request) | ||
|
|
||
| const message = await stream.first() | ||
| let response = Response.decode(message) | ||
| expect(response.type).to.eql(Response.Type.OK) | ||
| expect(response.peerStore).to.eql({ | ||
|
There was a problem hiding this comment. Why not
There was a problem hiding this comment.
|
||
| protos: [ | ||
| '/mplex/6.7.0', | ||
| '/ipfs/id/1.0.0', | ||
| '/ipfs/ping/1.0.0', | ||
| '/libp2p/circuit/relay/0.1.0', | ||
| '/ipfs/kad/1.0.0' | ||
| ], | ||
| peer: null | ||
| }) | ||
| stream.end() | ||
| }) | ||
|
|
||
| it('NOT IMPLEMENTED get peer info', async () => { | ||
| client = new Client(daemonAddr) | ||
|
|
||
| await client.attach() | ||
|
|
||
| const request = { | ||
| type: Request.Type.PEERSTORE, | ||
| peerStore: { | ||
| type: PeerstoreRequest.Type.GET_PEER_INFO, | ||
| id: Buffer.from(libp2pPeer.peerInfo.id.toBytes()) | ||
| } | ||
| } | ||
|
|
||
| const stream = client.send(request) | ||
|
|
||
| const message = await stream.first() | ||
| let response = Response.decode(message) | ||
| expect(response.type).to.eql(Response.Type.ERROR) | ||
| expect(response.error.msg).to.eql('ERR_NOT_IMPLEMENTED') | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the remaining types of
PeerstoreRequest?libp2p/go-libp2p-daemon#91/files#diff-d864c93b68284fafd809efbf29a1f0ebR166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I noticed that you have only implemented
GET_PROTOCOLShere.Can I recommend adding the other ones and then throw a
ERR_NOT_IMPLEMENTEDfor that? Moreover, can you create an issue for tracking the remaining ones?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll create an issue for when the spec gets done. I only added these initial two, as those likely won't change, but since the spec is still being discussed it didn't make sense to me to pull in a bunch of theoretical types.
I'll add
ERR_NOT_IMPLEMENTEDfor the types that are currently in the proto file.