integration: add circuit v2 transport integration test #3392
Conversation
|
Did you use an LLM to help generate this PR? We kindly ask that you must disclose that:
The goal is to add circuitv2 to the existing transport integration tests, not to create a new one. See https://github.com/libp2p/go-libp2p/pull/3162/files for some initial work. |
No there is not any LLM used here just use it to understand the thing how the curcuitv2 works. Yes, I will mention in pr if any AI is used. I understand what you mean for the issue I think I misunderstood this issue. |
|
Thank you! |
|
@MarcoPolo Please have a look. |
p2p/test/transport/transport_test.go
Outdated
| finalLibp2pOpts := transformOpts(opts) | ||
| finalLibp2pOpts = append(finalLibp2pOpts, | ||
| libp2p.Identity(listenerHost.Peerstore().PrivKey(listenerHost.ID())), | ||
| libp2p.EnableRelay(), | ||
| libp2p.AddrsFactory(addrFactory), | ||
| libp2p.ListenAddrStrings("/ip4/127.0.0.1/udp/0/quic-v1"), | ||
| ) | ||
|
|
||
| finalHost, err := libp2p.New(finalLibp2pOpts...) | ||
| require.NoError(t, err) | ||
|
|
||
| err = finalHost.Connect(ctx, peer.AddrInfo{ | ||
| ID: relayHost.ID(), | ||
| Addrs: relayHost.Addrs(), | ||
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = client.Reserve(ctx, finalHost, peer.AddrInfo{ | ||
| ID: relayHost.ID(), | ||
| Addrs: relayHost.Addrs(), | ||
| }) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Why is there a 3rd host? You have the listener, relay, and "final."
There was a problem hiding this comment.
Yes I think i overcomplicate this
I am making some changes
|
Next time, please run the tests before submitting a PR. |
|
@MarcoPolo I changed some part of code. |
The purpose of these tests is to test all aspects of a transport, not just the ability to send ping a small message. The failures are likely related to something about the circuitv2 transport. While we could skip every test that fails in circuitv2, I'd rather we attempt to fix the issues. |
For testing :
go test ./p2p/test/transport -v -run TestPingFixes: #3095