basichost: improve autonatv2 reachability logic #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
91d3854 to
611df04
Compare
sukunrt
force-pushed
the
sukun/an-logic
branch
2 times, most recently
from
791cacb to
d2e6f83
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
611df04 to
8be2504
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
8be2504 to
b8d1eab
Compare
sukunrt
force-pushed
the
sukun/an-logic
branch
2 times, most recently
from
b49b95c to
139e307
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
2 times, most recently
from
d388884 to
4d77c2b
Compare
sukunrt
force-pushed
the
sukun/an-logic
branch
2 times, most recently
from
49d58c5 to
e9e77a1
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
4d77c2b to
51add1c
Compare
We'll deprecate this event, but we still have to keep sending this for a few more releases. More importantly, we need to update the peerstore with the host's addresses and it's better to do this *before* sending update events so that consumers of the event can rely on the host addrs being updated in the peerstore.
sukunrt
force-pushed
the
sukun/an-logic
branch
from
e9e77a1 to
1c6037b
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
51add1c to
2346193
Compare
sukunrt
force-pushed
the
sukun/an-logic
branch
from
1c6037b to
5854b79
Compare
This improves the reachability detection logic by introducing the concept of primary and secondary addresses. If we have a webtransport address which shares the IP and Port with a QUIC address, the WebTransport address will be considered secondary and the QUIC address will be considered primary. If the Primary is reachable or unreachable, we require only one confirmation for the Secondary address. This speeds up address verification considerably.
sukunrt
force-pushed
the
sukun/an-logic
branch
from
5854b79 to
a29a664
Compare
Why isn't this based on just the "thinwaist" aspect rather than the transport? If my IP + UDP port is reachable, then it very likely doesn't matter if I'm running QUIC, WebTransport, or WebRTC |
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
4 times, most recently
from
e675e47 to
ecab374
Compare
sukunrt
force-pushed
the
sukun/basichost-evtlocaladdrs
branch
from
ecab374 to
4fb69b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the reachability detection logic by introducing the concept of primary and secondary addresses. If we have a webtransport address which shares the IP and Port with a QUIC address, the WebTransport address will be considered secondary and the QUIC address will be considered primary.
If the Primary is reachable or unreachable, we require only one confirmation for the Secondary address. This speeds up address verification considerably.