Skip to content

fix: remove duplicate listen addresses to avoid muxer panic #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove duplicate listen addresses to avoid muxer panic #3347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,26 @@ func (cfg *Config) validate() error {
return errors.New("cannot use shared TCP listener with PSK")
}

// check for duplicate listen addresses and remove them
listenAddresses := cfg.ListenAddrs
// Remove duplicates while keeping the first occurrence of each address
seen := make(map[string]bool)
listenAddresses = slices.DeleteFunc(listenAddresses, func(addr ma.Multiaddr) bool {
addrStr := addr.String()
if seen[addrStr] {
return true // Remove this duplicate
}
seen[addrStr] = true
return false // Keep this first occurrence
})
cfg.ListenAddrs = listenAddresses
return nil
}

// NewNode constructs a new libp2p Host from the Config.
//
// This function consumes the config. Do not reuse it (really!).
func (cfg *Config) NewNode() (host.Host, error) {

validateErr := cfg.validate()
if validateErr != nil {
if cfg.ResourceManager != nil {
Expand Down