Add deployed apps gateway #178
Conversation
Summary of ChangesHello @kapicic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the platform's ability to manage and display deployed applications. It introduces a robust 'app viewer' that allows users to access their deployed projects through friendly, slug-based URLs directly within the application. This is achieved by integrating iframe-based viewing, implementing a comprehensive slug generation and validation system, and configuring critical security headers on deployment platforms to facilitate cross-origin embedding. The changes aim to streamline the workflow for reviewing and interacting with deployed projects. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant new feature: an app gateway for viewing deployed applications using iframes and human-readable slugs. The changes are extensive, touching frontend components, API routes, deployment plugins, and the database schema. My review has identified two critical security vulnerabilities in the new app viewer pages that allow unauthorized access to private applications. Additionally, there are several medium-severity issues related to type safety (use of any), code duplication, and maintainability that should be addressed.
| try { | ||
| await requireUserId(request); | ||
|
|
||
| const { baseSlug, chatId, siteName, existingSlug } = await request.json<any>(); // TODO: type |
There was a problem hiding this comment.
Is it worth handling this TODO and any now? Or do you expect this in a future PR?
| import { AlertCircle, ExternalLink, Globe, Loader2, Maximize2, Minimize2, RefreshCw, Settings } from 'lucide-react'; | ||
| import { classNames } from '~/utils/classNames'; | ||
|
|
||
| type Website = any; // TODO |
2 participants
📋 Pull Request Summary
WIP: need to resolve some bugs with Netlify production headers
Use iframe to proxy apps from deployed platforms to our builder.
Use slugs to have human readable urls.
Update websites table to store slugs.
Update deployment methods to set CORS headers.
TODO: allow only from builder origin
🔗 Related Issues
📝 Changes Made
🧪 Testing
Testing Details:
📚 Documentation
🔄 Type of Change
🚨 Breaking Changes
Breaking Change Details:
📸 Screenshots/Videos
📋 Additional Notes