Skip to content

Adjust GlobalNav width from 176px to 240px #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2025
Merged

Adjust GlobalNav width from 176px to 240px #3925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
444d8cb
feat: adjust GlobalNav width from 176px to 240px
devin-ai-integration[bot] Oct 29, 2025
b6f31e6
chore: add changeset for GlobalNav width adjustment
devin-ai-integration[bot] Oct 29, 2025
9e930c4
fix(app): Improve GlobalNav text overflow handling and remove publish…
NoritakaIkeda Oct 30, 2025
d4779ec
Merge branch 'main' into devin/1761718819-adjust-globalnav-width
NoritakaIkeda Oct 30, 2025
96eeaae
feat(app): Center-align GlobalNav button content
github-actions[bot] Oct 31, 2025
afea08e
feat(app): Add grid layout and label area to NewSessionButton
NoritakaIkeda Nov 4, 2025
9ddf09a
feat(app): Hide NewSessionButton icon on GlobalNav hover
NoritakaIkeda Nov 4, 2025
e8babbc
refactor(app): Simplify NewSessionButton label styling
NoritakaIkeda Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/apps/app/components/CommonLayout/GlobalNav/GlobalNav.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* Menu open state specific to CommonLayout */
.globalNav:has([data-radix-menu-content][data-state='open']) {
width: 11rem;
width: 15rem;
box-shadow: 4px 0 16px rgba(0, 0, 0, 0.2);
}

Expand Down
7 changes: 6 additions & 1 deletion frontend/apps/app/components/CommonLayout/GlobalNav/Item.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
.item {
gap: var(--spacing-2half);
width: auto;
justify-content: center;
}

.iconContainer > svg {
Expand All @@ -35,8 +36,10 @@

.labelArea {
display: flex;
gap: var(--spacing-2);
align-items: center;
gap: var(--spacing-2);
flex: 1;
min-width: 0;
opacity: 0;
transition: opacity 0.1s var(--default-timing-function);
}
Expand All @@ -50,6 +53,8 @@
}

.label {
flex: 1;
min-width: 0;
overflow: hidden;
text-overflow: ellipsis;
font-size: var(--font-size-4, 0.8125rem);
Expand Down
33 changes: 33 additions & 0 deletions ...d/apps/app/components/CommonLayout/GlobalNav/NewSessionButton/NewSessionButton.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
.newSessionButton {
display: grid;
grid-auto-flow: column;
align-items: center;
justify-content: center;
justify-items: center;
column-gap: var(--spacing-2half);
color: var(--button-primary-foreground);
background-color: var(--button-primary-background);
border: var(--border-width-base) solid var(--button-primary-background);
Expand All @@ -12,3 +18,30 @@
.newSessionButton .icon {
color: var(--button-primary-foreground);
}

.iconContainer {
display: flex;
}

:global([data-global-nav-container]):hover .newSessionButton .iconContainer,
:global([data-global-nav-container]):has(
[data-radix-menu-content][data-state='open']
)
.newSessionButton
.iconContainer {
display: none;
}

.labelArea {
display: none;
justify-content: center;
}

:global([data-global-nav-container]):hover .newSessionButton .labelArea,
:global([data-global-nav-container]):has(
[data-radix-menu-content][data-state='open']
)
.newSessionButton
.labelArea {
display: flex;
}
6 changes: 3 additions & 3 deletions frontend/apps/app/components/CommonLayout/GlobalNav/NewSessionButton/NewSessionButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ export const NewSessionButton: FC = () => {
href={urlgen('design_sessions/new')}
className={clsx(itemStyles.item, styles.newSessionButton)}
>
<div className={itemStyles.iconContainer}>
<div className={clsx(itemStyles.iconContainer, styles.iconContainer)}>
<MessageCircleIcon className={styles.icon} />
</div>
<div className={itemStyles.labelArea}>
<span className={itemStyles.label}>New Session</span>
<div className={clsx(itemStyles.labelArea, styles.labelArea)}>
<span className={clsx(itemStyles.label)}>New Session</span>
</div>
</Link>
)
Expand Down
3 changes: 2 additions & 1 deletion ...lobalNav/RecentsSection/components/SessionFilterDropdown/SessionFilterDropdown.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
width: 0.75rem;
height: 0.75rem;
color: var(--overlay-70);
margin-left: auto;
}

.dropdownContent {
min-width: 200px;
width: 15rem;
}
2 changes: 1 addition & 1 deletion frontend/packages/ui/src/components/BaseGlobalNav/BaseGlobalNav.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
}

:not([data-disable-hover]) > .globalNav:hover {
width: 11rem;
width: 15rem;
box-shadow: 4px 0 16px rgba(0, 0, 0, 0.2);
}

Expand Down