patmos and s4noc support #288

EhsanKhodadad · 2025-06-05T16:00:29Z

No description provided.

tanneberger

Generally looks pretty good so far!

I will probably make a second round to precisely understand your stuff.

=> run make format to format all the code.
=> also checkout what clang-tidy has to say about your code.

src/platform/patmos/patmos.c

tanneberger · 2025-06-07T00:10:01Z

src/platform/patmos/s4noc_channel.c

+    *((int *)self->write_buffer) = message_size;
+
+    int total_size = message_size + 4;
+    *s4noc_dest = self->destination_core;


uhh I dont know if this plays nicely if you have multiple S4NOC Channels sending to different cores.

tanneberger · 2025-06-07T00:11:29Z

src/platform/patmos/s4noc_channel.c

+    return;
+  }
+
+  int value = *s4noc_data;


how fast do we need to poll, this function so no data loss occurs?

tanneberger · 2025-06-07T00:12:02Z

src/startup_coordinator.c

    case StartupCoordinationState_RUNNING:
      // Should not be possible.
-      validate(false);
+      // validate(false);


I want that back ;D

In file included from /home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/src-gen/MyFed/src/reactor-uc/include/reactor-uc/startup_coordinator.h:4,
from /home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/src-gen/MyFed/src/reactor-uc/src/startup_coordinator.c:1:
/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/src-gen/MyFed/src/reactor-uc/src/startup_coordinator.c: In function ‘StartupCoordinator_handle_start_time_proposal’:
/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/src-gen/MyFed/src/reactor-uc/include/reactor-uc/error.h:32:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
32 | if ((expr) == 0) {
| ^
/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/src-gen/MyFed/src/reactor-uc/src/startup_coordinator.c:253:7: note: in expansion of macro ‘validate’
253 | validate(false);
| ^~~~~~~~
/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/src-gen/MyFed/src/reactor-uc/src/startup_coordinator.c:254:5: note: here
254 | case StartupCoordinationState_HANDSHAKING:
| ^~~~
cc1: all warnings being treated as errors
gmake[3]: *** [src-gen/MyFed/src/reactor-uc/CMakeFiles/reactor-uc.dir/build.make:331: src-gen/MyFed/src/reactor-uc/CMakeFiles/reactor-uc.dir/src/startup_coordinator.c.o] Error 1
gmake[3]: Leaving directory '/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/build'
gmake[2]: *** [CMakeFiles/Makefile2:145: src-gen/MyFed/src/reactor-uc/CMakeFiles/reactor-uc.dir/all] Error 2
gmake[2]: Leaving directory '/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/build'
gmake[1]: *** [Makefile:91: all] Error 2
gmake[1]: Leaving directory '/home/ehsan/lf-pat-mul/reactor-uc/examples/fed-template/MyFed/src/build'
make: *** [Makefile:29: examples] Error 2

@EhsanKhodadad try putting a breakl; behind the validate.

no difference

test/platform/patmos/hello/hello.c

tanneberger · 2025-06-07T00:12:49Z

test/platform/patmos/s4noc_channel_test/main.c

+
+bool receiver_callback_called = false;
+
+void setUp(void) {


in this code base we generally used sneak_case

setUp and teadDown are weakly defined in test/unit/mock.c and used widely with the same name.

tanneberger · 2025-06-07T00:14:06Z

test/platform/patmos/s4noc_test/main.c

+    return 0;
+}
+
+int lf_sleep(interval_t sleep_duration) {


how about you just include your patmos.cfor those functions?

tanneberger · 2025-06-07T00:14:32Z

test/platform/patmos/s4noc_test/main.c

+    return counter++; // Incremental values
+}
+
+#define MAX_ITER 5


please at the top of the file

examples/patmos/buildAll.sh

include/reactor-uc/tag.h

tanneberger · 2025-06-10T23:06:57Z

lfc/core/src/main/kotlin/org/lflang/generator/uc/UcFederatedProjectTemplateGenerator.kt

+            .trimMargin()
+    FileUtil.writeToFile(make, projectRoot.resolve("Makefile"))
+  }
+


Relocate this into the patmos template repo.

tanneberger · 2025-06-10T23:10:52Z

lfc/core/src/main/kotlin/org/lflang/generator/uc/UcNetworkChannel.kt

+
+  companion object {
+    fun fromAttribute(federate: UcFederate, attr: Attribute): UcS4NocInterface {
+      val s4nocId = attr.getParamInt("s4noc_id") ?: 0


I dont get this. what is the s4noc_id and port?

I thought you basically only need, what is my current core and what is the core the other federate runs on?

tanneberger · 2025-06-16T13:01:25Z

examples/patmos/s4noc_lf/src/s4noc.lf

+  =}
+}
+
+main reactor {


this should be federated instead of main

…ded.

EhsanKhodadad · 2025-08-14T13:43:17Z

Current output:

(170000000) [DEBUG] [SCHED] Scheduler running with keep_a4iv1=00m00) [DEBUG] [FED] S4NoCFedLF_r2 Established connection to all[34me18r2te00pe rsEB0m] [SCHED] Polling network channels
(190675000) [INFO] [NET] S4NOCPollChannel: S4NOCPollChannel_poll: No data is availaml1
000) [DEBUG] [QUEUE] Inserting event with tag (8302395121467392,0) into EventQueue
(210314000) [DEBUG][34m(20]811a00fy[DgBUven[QCHuD]atexn ex ns
a system_event at (8583904458059988,0)
(220430000) [DEBUG] [SCHED] Scheduler running with keep_alive=[340(224909000) [DEBUG] [QUEUE] Popping event from EventQueue
[34m(230663000) [DEBUG] [SCHED] Polling network channels
(241115000) [INFO] [NET] S4NOCPollChannel: S4NOCPoll[hamne3_086000) [DEBUG] [SCHED] Handling system event 0x1e7ebc for tag (8583612400140289,0)
(258114000) [DEBUG] [CLOCK_SYNC] Handle ClockSy3c (2s32m 0ve)t 7EfrGm [SigEbor -1t[ev
nt is a system_event at (8302481020956884,0)
(270142000) [DEBUG] [CLOCK_SYNC] Broadcasting priority 0 to all nei3hb(rs000) [DEBUG] [QUEUE] Popping event from EventQueue
(284769000) [DEBUG] [NET] S4NOCPollChannel: S4NOCPollChannel_send_blocking: message size: ((7)).
(286577000) [DEBUG] [SCHED] Handling system event 0x1[74m(29o98ta0 ( [02B88]63NE71 5,NOmlChannel: Total size to send: ((11))
(307189000) [DEBUG] [CLOCK_SYNC] Handle ClockSync system4ev3nt663f00) [DiBUG]r[NET[ S4NOCPollChannel: Sent ((12)) bytes
m319247000) [DEBUG] [CLOCK_SYNC] No master neighbor, w4it322712000) [DEBUG]n[SCHED] Polling network channels
[NET] S4NOCPollChannel: S4NOCPollChannel_poll: No data is available
(341412000) [DEBUG] [QUEUE] Inserting event with tag (8301811005915136,0) i[3om(ven858000) [m
BUG] [SCHED] Next event is a system_event at (8583904459914944,[)0362024000) [DEBUG] [QUEUE] Heapifying EventQueue at index 0
(373701000) [DEBUG] [SCHED] Polling network channels
(382841000) [INFO] [NET] S4NOCPollChannel: S4NOCPollChannel_po[34m(e8ei1ed 0at[ 0BU00000U7 E]o) inomesonr fr1mentQueue
(398454000) [DEBUG] [NET] S4NOCPollChannel: receive_buffer_index ((4))
(399774000) [DEBUG] [SCHED] [anmli09 99st0) [DenU 0 [eETbcSfoOCtal Cha8ne12400pe02ed,meam
size: ((7))
(420442000) [DEBUG] [FED] Received handshake request from self
(422038000) [DEBUG] [SCHED] Next event is a(43ev5nt00t [83BU4]102E74 S4NO0)ol0mhannel: S4NOCPollChannel_send_blocking: message size: ((5)).
(442800000) [DEBUG] [QUEUE] Popping event from EventQueue3
m(447395000) [DEBUG] [NET] S4NOCPollChannel: Total size to send: ((9))
(459739000) [DEBUG] [NET] S4NOCPollm(an3el:0Se)t ((B2G) [yteE
ndling system event 0x1d7ec8 for tag (8302188963037185,0)(470373000) [DEBUG] [SCHED] Polling network channels
[34m(475607000) [DEBUG] [FED] Received handshake request from[30m(
6000) [INFO] [NET] S4NOCPollChannel: S4NOCPollChannel_poll: No data is available
(489258000) [DEBUG] [NET] S4NOCPollChannel: S4NOCPollChannel_send_blocking: message size: ((5)).
(503652000) [DEBUG] [NET] S4NOCPollCh[34ml49T5ta00si e EB s]ndS (ED))N[0t event is at (8583852920307392,2147483647)
(514537000) [DEBUG] [NET] S4NOCPollChannel: Sent ((12)) bytes
(525160000) [DEBUG] [SCHED] Polling network channels
(518541000) [DEBUG] [SCHED] Next event is beyond or at stop tag: (1780298325(53835,000)4[3NF7] [0ET] S4NOCPollChannel: S4NOCPollChannel_poll: Received data 0x06220412 (") from source 1
(551432000) [DEBUG] [NET] S4NOCPollChannel: receive_buffer_index ((8))
(562429000) [DEBUG] [NET] S4NOCPollChannel: Expected message size: ((7))
(573731000) [DEBUG] [SCHED] Next event is a system_event at (8302481022746316,0)
(1340479000) [DEBUG] [QUEUE] Popping event from EventQueue
(1350750000) [DEBUG] [SCHED] Handling system event 0x1d7ec8 for tag (8302188963037185,0)
(1371858000) [DEBUG] [CLOCK_SYNC] Handle ClockSync system event 3 from neighbor -1
(1384420000) [DEBUG] [CLOCK_SYNC] No master neighbor, wait for next sync round.
(1396284000) [DEBUG] [CLOCK_SYNC] Scheduling next RequestSync
(1407559000) [DEBUG] [QUEUE] Inserting event with tag (8301811005915136,0) into EventQueue
(1428834000) [DEBUG] [SCHED] Polling network channels
(1438442000) [INFO] [NET] S4NOCPollChannel: S4NOCPollChannel_poll: Received data 0x02080000 ) from source 1
(1454533000) [DEBUG] [NET] S4NOCPollChannel: receive_buffer_index ((12))
(1466311000) [DEBUG] [NET] S4NOCPollChannel: Expected message size: ((7))
(1479537000) [WARN] [NET] S4NOCPollChannel: No receive callback registered, dropping message
(1492669000) [DEBUG] [SCHED] Next event is a system_event at (8302481022746316,0)

EhsanKhodadad · 2025-08-14T13:44:04Z

PlatformPatmos_wait_until_interruptible will be changed in the next commit.

EhsanKhodadad added 5 commits May 27, 2025 16:29

Patmos and S4NoC support: init commit

a2bb5ac

Patmos and S4NoC support: 2nd commit

47125dc

Patmos and S4NoC: 3rd Commit

7e2886c

Patmos and s4noc: 4th Commit: s4noc_channel passed the test

f6f5e65

Patmos and s4noc support

1729aa4

tanneberger requested changes Jun 7, 2025

View reviewed changes

Patmos and s4noc support: 6

59c00dc

tanneberger reviewed Jun 10, 2025

View reviewed changes

tanneberger added enhancement New feature or request platform Platform support labels Jun 11, 2025

tanneberger assigned tanneberger and EhsanKhodadad and unassigned tanneberger Jun 11, 2025

Patmos and s4noc : 7

3757bff

tanneberger reviewed Jun 16, 2025

View reviewed changes

examples/patmos/s4noc_lf/src/s4noc.lf Outdated

=}

}

main reactor {

Copy link

Member

tanneberger Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be federated instead of main

EhsanKhodadad added 6 commits June 19, 2025 14:37

Patmos and S4NoC: 8

bb64102

Patmos and S4NoC 9

5ff668e

Patmos and S4NoC 10: manipulator to the second-to-last reactors is ad…

5a50c9b

…ded.

Patmos and S4NoC 11: compiled

f3b315a

stuck at receive

0172e2f

Recieves with long delay and lacks cb

b5329af

EhsanKhodadad added 5 commits August 18, 2025 15:13

fpga config and download

1af63f7

failed on fpga solved

3240bd6

global state are set in channel

74dc986

loop in build.sh

8544881

main file generator

f31281b

patmos and s4noc support #288

Are you sure you want to change the base?

patmos and s4noc support #288

Uh oh!

Conversation

EhsanKhodadad commented Jun 5, 2025

Uh oh!

tanneberger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EhsanKhodadad commented Aug 14, 2025

Uh oh!

EhsanKhodadad commented Aug 14, 2025

Uh oh!

Uh oh!