Skip to content

Conversation

JaGeo
Copy link

@JaGeo JaGeo commented Jul 29, 2024

Summary

It seems to partially run now. I added one job argument and will now try to debug the other parts as well.

I would, however, recommend that you move the code to "common/flow/pheasy.py" and "common/jobs/pheasy.py" instead of directly changing the phonon.py files. If you ever want to merge it to the main branch of atomate2, this would take some time to fix. Let's rather do it now.

@JaGeo
Copy link
Author

JaGeo commented Jul 29, 2024

I am not sure the adding and running of additional phonon displacement works as intended yet but at least all code is connected. I think you can take over now again and try to fix the rest of the code (and make the suggested changes from above)

@leslie-zheng
Copy link
Owner

I am not sure the adding and running of additional phonon displacement works as intended yet but at least all code is connected. I think you can take over now again and try to fix the rest of the code (and make the suggested changes from above)

very appreciate and will do it.

@leslie-zheng
Copy link
Owner

Summary

It seems to partially run now. I added one job argument and will now try to debug the other parts as well.

I would, however, recommend that you move the code to "common/flow/pheasy.py" and "common/jobs/pheasy.py" instead of directly changing the phonon.py files. If you ever want to merge it to the main branch of atomate2, this would take some time to fix. Let's rather do it now.

Sure, we want to merge into the main branch in the future, will move the code to "common/flow/pheasy.py" and "common/jobs/pheasy.py" at the same time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with this test so far. Might be faster than debugging with the vasp jobs

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Janine, that is really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants