Skip to content

Develop -> main #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 12, 2024
Merged

Develop -> main #6

merged 10 commits into from
Mar 12, 2024

Conversation

hrak
Copy link
Member

@hrak hrak commented Mar 12, 2024

This PR contains the following changes:

Pearl1594 and others added 10 commits January 19, 2024 18:25
…ers (#56)

Currently CKP does not setup NetworkACLs for CKS clusters on VPC tiers, and fails to add Firewall rules - as Firewall isn't supported on VPCs. This is a partial fix, to skip setting up Firewall rules if the network doesn't support the service.
- convert providerID to instanceID where needed
- rename provider from external-cloudstack to cloudstack
- implement InstanceShutdown and InstanceShutdownByProviderID
This fixes problems with kube-proxy in ipvs mode considering the lb IP as local to the node
See kubernetes/kubernetes#66607
This can also be used to access PROXY proto service from the inside
@hrak hrak requested review from lanord and FarnazBGH March 12, 2024 09:38
Copy link
Collaborator

@FarnazBGH FarnazBGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrak hrak merged commit b33a30b into main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants