-
Notifications
You must be signed in to change notification settings - Fork 13
Update for Moodle 5.0 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/moodle-ci.yml
Outdated
name: "" | ||
uses: learnweb/moodle-workflows-learnweb/.github/workflows/moodle-ci.yml@main | ||
with: | ||
allow-mustache-lint-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only reasonable way at the moment, I guess...?
I have rebased the changes onto main and re-arranged some commits. I |
As discussed with @bluetom and @TamaroWalter I have removed two commits and pushed a v3 of this branch. We agreed on making the code checker ignore the thirdparty/ code since it violates Moodle coding standards anyway so there is no point in checking for it. @TamaroWalter will adapt the central Learnweb workflow files to make this work. Since we want to support 4.1 for a couple of weeks, we cannot upgrade the |
I have just noticed that the problems do not arise with the code checker. The |
This PR adapts the repo to the new changes of Moodle 5.0.
Changes made:
Todo's: