Skip to content

changed default grid gap to 24px of KCardGrid #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

shruti862
Copy link
Contributor

@shruti862 shruti862 commented Apr 19, 2025

Description

Changed default grid gap to 24px instead of 30px of KCardGrid.

Issue addressed

#996

Addresses #PR# HERE

Before/after screenshots

Before:
image

After:
image

Changelog

  • Description: Changed default grid gap to 24px instead of 30px of KCardGrid.
  • Products impact: KDS, Studio, Kolibri
  • Addresses: issue #996 and one related PR in kolibri #13344
  • Components: KCardGrid
  • Breaking: no
  • Impacts a11y: no
  • Guidance: none

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@MisRob
Copy link
Member

MisRob commented Apr 22, 2025

Hi @shruti862, thanks for these updates. In your pull requests, would you please upload before / after screenshots of the user experience - that is how the grid looks like before and after on affected places? We don't need screenshots of code, that's something reviewers can see in the pull requests diff.

@shruti862
Copy link
Contributor Author

Hi @shruti862, thanks for these updates. In your pull requests, would you please upload before / after screenshots of the user experience - that is how the grid looks like before and after on affected places? We don't need screenshots of code, that's something reviewers can see in the pull requests diff.

I have added the screenshot , let me know if any other changes needed :)

@MisRob
Copy link
Member

MisRob commented Apr 24, 2025

Thank you @shruti862, that's helpful.

@MisRob MisRob added the TODO: needs review Waiting for review label Apr 24, 2025
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @shruti862 !

Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too!

@nucleogenesis nucleogenesis merged commit 51c18f8 into learningequality:develop May 7, 2025
12 of 14 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants