-
Notifications
You must be signed in to change notification settings - Fork 60
fix and improve emailing class list aliases #3832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
milescalabresi
wants to merge
15
commits into
main
Choose a base branch
from
mailgate-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+102
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some additional ideas based on discussion:
|
We discussed a better way to do it.
|
With those changes, this should also fix #3760. |
willgearty
reviewed
Jun 11, 2025
willgearty
reviewed
Jun 11, 2025
Is the purpose of these changes to address the spam abuse reports? Will all emails be sent through SendGrid now? |
Yes, the vision is send all emails through SendGrid. That's one benefit but
not the only one
…On Fri, Jul 4, 2025 at 2:52 PM hwatheod ***@***.***> wrote:
*hwatheod* left a comment (learning-unlimited/ESP-Website#3832)
<#3832 (comment)>
Is the purpose of these changes to address the spam abuse reports? Will
all emails be sent through SendGrid now?
—
Reply to this email directly, view it on GitHub
<#3832 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKAJDY3HGWJLJC4F7DLXXT3G3EP5AVCNFSM6AAAAAB3VBISQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZXGA3DAOBWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace sha with hashlib for python3 to fix issue with emailing class list aliases