fix: correctly apply hint
priority (was always set to default 1000 due to a bug)
#30389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29831.
In addition to fixing the bug, this PR also adjusts the (now-working) tactic priorities to ensure that:
bound
is tested afteraesop
(bound
callsaesop
and is therefore stronger)group
is tested afterring
(group
callsring
and is therefore stronger)A bug in the parsing code below caused the priority value to be ignored, resulting in all hints using the default priority of 1000 regardless of the
register_hint
priority parameter:Fixed by simplifying the syntax to take a mandatory numeric priority argument and extracting it directly via
prio.raw.isNatLit?
, removing the index-based parsing and the silent fallback to 1000.