Skip to content

Conversation

HugLycan
Copy link
Contributor

@HugLycan HugLycan commented Oct 9, 2025


This PR adds support for positivity [h₁, h₂] syntax.
related issue #2427
@fpvandoorn

Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-meta Tactics, attributes or user commands labels Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

PR summary 06bd309675

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this; I have wanted this feature for a while!

It would be nice to document this a bit better, so users can learn what this does by just reading the documentation. (I'm also very curious to see how much of mathlib could be simplified with this, but that should probably happen in a separate pull request.)

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 10, 2025
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one tiny tweak. @fpvandoorn Would you like to take a final look?

Co-authored-by: Michael Rothgang <[email protected]>
@HugLycan
Copy link
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 10, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would, please add a simple test for positivity []; see other comment. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants