-
Notifications
You must be signed in to change notification settings - Fork 834
feat(Positivity): add support for positivity [h₁, h₂]
syntax
#30388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(Positivity): add support for positivity [h₁, h₂]
syntax
#30388
Conversation
PR summary 06bd309675Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this; I have wanted this feature for a while!
It would be nice to document this a bit better, so users can learn what this does by just reading the documentation. (I'm also very curious to see how much of mathlib could be simplified with this, but that should probably happen in a separate pull request.)
…an/mathlib4 into feat/positivity-with-hyps
…an/mathlib4 into feat/positivity-with-hyps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with one tiny tweak. @fpvandoorn Would you like to take a final look?
Co-authored-by: Michael Rothgang <[email protected]>
-awaiting-author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would, please add a simple test for positivity []
; see other comment. :)
This PR adds support for
positivity [h₁, h₂]
syntax.related issue #2427
@fpvandoorn