-
Notifications
You must be signed in to change notification settings - Fork 835
chore(FractionRing): generalize an instance #30364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(FractionRing): generalize an instance #30364
Conversation
PR summary 14d639db18Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
!bench |
Here are the benchmark results for commit 632367e. |
|
Sure, why not? Benchmarking seems fine. But a close look by an algebraist would be good. |
🚀 Pull request has been placed on the maintainer queue by grunweg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a strict generalization, right?
On the one hand, the goal is now more flexible, it can be any field K
, but on the other hand, K
now also appears as field amongst the assumptions, whereas C
only had to be a domain.
Well, what I meant is that Lean can deduce the original instance from the new one since |
The instance that deduce from a tower of domains
A ⊆ B ⊆ C
that there is a towerFrac A ⊆ Frac B ⊆ Frac C
can be generalized toA ⊆ B ⊆ K
impliesFrac A ⊆ Frac B ⊆ K
whereK
is a field (and exactly the same proof works!).