Skip to content

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Oct 9, 2025

The instance that deduce from a tower of domains A ⊆ B ⊆ C that there is a tower Frac A ⊆ Frac B ⊆ Frac C can be generalized to A ⊆ B ⊆ K implies Frac A ⊆ Frac B ⊆ K where K is a field (and exactly the same proof works!).


@github-actions github-actions bot added the t-ring-theory Ring theory label Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

PR summary 14d639db18

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (B K : Type*) [CommRing B] [IsDomain B] [Field K] [Algebra A B]
- instance (B C : Type*) [CommRing B] [IsDomain B] [CommRing C] [IsDomain C] [Algebra A B]

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xroblot xroblot added the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Oct 9, 2025
@leanprover-community-mathlib4-bot
Copy link
Collaborator

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 632367e.
There were no significant changes against commit 14d639d.

Copy link

github-actions bot commented Oct 9, 2025

File Instructions %
build +9.190⬝10⁹ (+0.00%)
Mathlib.RingTheory.IntegralClosure.IntegralRestrict +3.259⬝10⁹ (+1.21%)
Mathlib.AlgebraicGeometry.GammaSpecAdjunction +1.52⬝10⁹ (+1.38%)
Mathlib.RingTheory.Localization.FractionRing -5.419⬝10⁹ (-8.94%)
CI run Lakeprof report

@github-actions github-actions bot removed the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Oct 9, 2025
@grunweg
Copy link
Collaborator

grunweg commented Oct 9, 2025

Sure, why not? Benchmarking seems fine. But a close look by an algebraist would be good.
maintainer merge?

Copy link

github-actions bot commented Oct 9, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a strict generalization, right?

On the one hand, the goal is now more flexible, it can be any field K, but on the other hand, K now also appears as field amongst the assumptions, whereas C only had to be a domain.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes. and removed maintainer-merge labels Oct 9, 2025
@xroblot
Copy link
Collaborator Author

xroblot commented Oct 9, 2025

This isn't a strict generalization, right?

On the one hand, the goal is now more flexible, it can be any field K, but on the other hand, K now also appears as field amongst the assumptions, whereas C only had to be a domain.

Well, what I meant is that Lean can deduce the original instance from the new one since IsScalarTower A B C implies IsScalarTower A B (FractionRing C) thanks to OreLocalization.instIsScalarTower

@xroblot xroblot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants