-
Notifications
You must be signed in to change notification settings - Fork 5
WIP: parse headings containing RDFa as block_rdfa
#1329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a086289
to
ab31283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For existing headings with links (made using the rdfaAware mode), this seems to work as expected, so I think just keeping the config option, but deprecating it, would work well to make this backwards compatible.
It seems that now there is a difference between headings that are loaded and headings that are inserted, as in order to insert a heading with an RDFa block, it's necessary to both insert the block and the heading. I think the most expected behaviour would be to parse headings created with RdfaAware: true
as just a heading if they do not have any backlinks, and only with a wrapping block if they do. Alternatively, we could always insert a block_rdfa with every heading, but I think this would be more confusing...
Overview
While we technically support rdfa on heading nodes, we don't really support it in a user-friendly/good way.
To solve this issue, we could parse headings containing RDFa as
block_rdfa
nodes containing a simple heading node (without RDFa). An example of such a solution is included in this PR.How to test/reproduce
block_rdfa
node (containing the RDFa) with a simpleheading
node inside.Challenges/uncertainties
heading
.Checks PR readiness