Fix: Sticky Behavior for currency Dropdown #6951 #6967
+90
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview for commit 63b051f at: https://68dd8836b9de0b363499f53c--layer5.netlify.app |
sudhanshutech
suggested changes
Oct 2, 2025
|
|
||
| // Lock both <html> and <body> while the dropdown is open | ||
| useEffect(() => { | ||
| if (!open) return; |
There was a problem hiding this comment.
this logic seems bit low level. Why the disableScrollLock is not working? Try using modal component and see if its wokring without such logic to handle manually the scrolling
There was a problem hiding this comment.
You're right
I tried using the standard MUI components first, but a CSS conflict elsewhere in the app was preventing them from working correctly.
This manual useEffect is a necessary override
|
@ChetanFTW please tag the pr with respective issue |
|
hi @sudhanshutech, mention in description now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is issue #6951
On this Page there is the dropdown while click to currency
Notes for Reviewers
Signed commits