-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: popup also in kanvas page #6923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: popup also in kanvas page #6923
Conversation
Signed-off-by: Lorenzo Croce <[email protected]>
🚀 Preview for commit 1e7a0b5 at: https://68d9586ea331b3f124ca6f80--layer5.netlify.app |
Signed-off-by: Lorenzo Croce <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Preview for commit 70adf95 at: https://68d95c1b6334ac0f6c10076f--layer5.netlify.app |
Thanks for the feedback @Rajesh-Nagarajan-11 |
Signed-off-by: Lorenzo Croce <[email protected]>
🚀 Preview for commit 9d5a109 at: https://68d989976b775291163e050b--layer5.netlify.app |
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
@Fireentity Im not sure about that , did you got insights from website meeting ? |
@Rajesh-Nagarajan-11 |
@Fireentity Could you please share what help you wanted , let me try to help you if possible |
@Rajesh-Nagarajan-11 |
In this page https://layer5.io/cloud-native-management/kanvas/collaborate you can find a animated image If possible you can create a pop with same animated one that will looks perfect |
https://layer5.io/company/brand here you can get some brand template that might helpful to build popup |
Signed-off-by: Lorenzo Croce <[email protected]>
🚀 Preview for commit de63184 at: https://68de962fbaee359c4319e9a8--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fireentity Really looks good please increase bit height ( very bit ) of popup will be super clean
Signed-off-by: Lorenzo Croce <[email protected]>
🚀 Preview for commit 537b953 at: https://68e10f88e7ed381c74dacf78--layer5.netlify.app |
@leecalcote He implemented in kanvas page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, good
Description
This PR fixes #6444
Notes for Reviewers
Signed commits