-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix: Eliminate two build warnings #6861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: Eliminate two build warnings #6861
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rethink this.
Too fragile. |
🚀 Preview for commit 4a040eb at: https://68d2c06d99a3d646bf7d8bef--layer5.netlify.app |
… that exists Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
|
🚀 Preview for commit db96801 at: https://68d2c50d0012c15cdb604f2e--layer5.netlify.app |
@Rajesh-Nagarajan-11 we shouldnt be doing this . rather than skipping files with broken or wrong imports we need to fix the import paths for these files or how we reference the components inside those files. this will only hide the problem under the rug and cause more pain |
@aabidsofi19 , We don't have and not needed Code.js and Guidance.js for Icons alone , that's a root cause of this issue. Could share your approach to solve this issue ? |
@leecalcote @aabidsofi19 Can i just replicate the overview content of icons to guidance and code as well ? Or else suggest me the approach, I don't know other than this : ( |
@Rajesh-Nagarajan-11 We are using it inside index.js instead of creating a separate code.js, and the same applies to guidance.js. You can check it here |
@saurabhraghuvanshii I don't think that's work , because build script searches for 3 file with their names. , instead of creating separate files ( code.js , guidance.js) , I kept all in index.js won't resolve the warning ->> https://github.com/layer5io/layer5/blob/master/gatsby-node.js#L799-L803 |
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
🚀 Preview for commit 5b8ee53 at: https://68d376f87aa058f0d2938fe8--layer5.netlify.app |
Description
This PR fixes #6846
This PR addresses the build warnings caused by missing files in the sistent/components/icons directory.
Before :

After :

Notes for Reviewers
Signed commits