Skip to content

Conversation

Rajesh-Nagarajan-11
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 commented Sep 23, 2025

Description

This PR fixes #6846
This PR addresses the build warnings caused by missing files in the sistent/components/icons directory.

Before :
Screenshot from 2025-09-23 20-45-51

After :
Screenshot from 2025-09-23 20-56-44

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 changed the title Fix: Eliminate two build warnings by removing missing icon page references Fix: Eliminate two build warnings Sep 23, 2025
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rethink this.

@leecalcote
Copy link
Member

Too fragile.

@l5io
Copy link
Contributor

l5io commented Sep 23, 2025

🚀 Preview for commit 4a040eb at: https://68d2c06d99a3d646bf7d8bef--layer5.netlify.app

@Rajesh-Nagarajan-11
Copy link
Member Author

Rajesh-Nagarajan-11 commented Sep 23, 2025

@leecalcote

  • The build script now dynamically checks for the existence of each expected file before attempting to create a page.
  • Pages are only created for files that actually exist, eliminating unnecessary build warnings and making the process more resilient to missing files.
  • This approach is generalized and does not rely on hardcoded exceptions for specific components, making it easier to maintain and extend in the future.

@l5io
Copy link
Contributor

l5io commented Sep 23, 2025

🚀 Preview for commit db96801 at: https://68d2c50d0012c15cdb604f2e--layer5.netlify.app

@aabidsofi19
Copy link
Contributor

@Rajesh-Nagarajan-11 we shouldnt be doing this . rather than skipping files with broken or wrong imports we need to fix the import paths for these files or how we reference the components inside those files. this will only hide the problem under the rug and cause more pain

@Rajesh-Nagarajan-11
Copy link
Member Author

Rajesh-Nagarajan-11 commented Sep 23, 2025

@aabidsofi19 , We don't have and not needed Code.js and Guidance.js for Icons alone , that's a root cause of this issue. Could share your approach to solve this issue ?

@Rajesh-Nagarajan-11
Copy link
Member Author

@leecalcote @aabidsofi19 Can i just replicate the overview content of icons to guidance and code as well ? Or else suggest me the approach, I don't know other than this : (

@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Sep 23, 2025

@Rajesh-Nagarajan-11 We are using it inside index.js instead of creating a separate code.js, and the same applies to guidance.js. You can check it here

@Rajesh-Nagarajan-11
Copy link
Member Author

@saurabhraghuvanshii I don't think that's work , because build script searches for 3 file with their names. , instead of creating separate files ( code.js , guidance.js) , I kept all in index.js won't resolve the warning

->> https://github.com/layer5io/layer5/blob/master/gatsby-node.js#L799-L803

Rajesh-Nagarajan-11 and others added 3 commits September 24, 2025 09:29
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 24, 2025

🚀 Preview for commit 5b8ee53 at: https://68d376f87aa058f0d2938fe8--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Eliminate two build warnings
5 participants