Skip to content

Conversation

ChetanFTW
Copy link
Member

…6776)

Description

This PR fixes #

Notes for Reviewers

  • Please test the card component on mobile, tablet, and desktop viewports.
  • Ensure no visual regressions appear in other components using the same card layout.
    Check out this layout video

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 2, 2025

🚀 Preview for commit 009e93b at: https://68b6f5efda4b2939463fa3b1--layer5.netlify.app

Copy link
Contributor

@vr-varad vr-varad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

this should not happen

position: relative;
width: 100%;
box-sizing: border-box;
padding: 0; // Remove negative padding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this comment for? @ChetanFTW

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will remove all padding entirely from "ColWrapper"

ChetanFTW added a commit to ChetanFTW/layer5 that referenced this pull request Sep 2, 2025
ChetanFTW added a commit to ChetanFTW/layer5 that referenced this pull request Sep 2, 2025
@l5io
Copy link
Contributor

l5io commented Sep 2, 2025

🚀 Preview for commit e280bda at: https://68b71053fd3c5e1c88e2da32--layer5.netlify.app

@ChetanFTW
Copy link
Member Author

image this should not happen

Now its all working fine check this video
improve_layout.webm

Feel free to let me know if there's anything for me.

@ChetanFTW
Copy link
Member Author

hey @vr-varad, I made some changes
can you check this video?

@l5io
Copy link
Contributor

l5io commented Sep 5, 2025

🚀 Preview for commit e00b5c0 at: https://68baf1a37c63d64cf5497de9--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Sep 5, 2025

🚀 Preview for commit aec90b3 at: https://68bb5950a1076046bbf27b2f--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Sep 6, 2025

🚀 Preview for commit af8d8c3 at: https://68bc90b4a587b746d3c0d38e--layer5.netlify.app

@vr-varad
Copy link
Contributor

vr-varad commented Sep 8, 2025

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Sep 8, 2025

🚀 Preview for commit be9b1bd at: https://68be54fa2eabde0a374884e2--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Sep 8, 2025

🚀 Preview for commit 5c210a7 at: https://68bec1bb52ec551ac676b541--layer5.netlify.app

@ChetanFTW ChetanFTW requested a review from vr-varad September 9, 2025 12:49
@l5io
Copy link
Contributor

l5io commented Sep 9, 2025

🚀 Preview for commit fcd2811 at: https://68c0257804b8b31091de08f5--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Sep 9, 2025

🚀 Preview for commit 5e7fe2a at: https://68c082d02443c78c89ba7970--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Sep 9, 2025

🚀 Preview for commit fcd2811 at: https://68c088e2446f6c9c3b02ca00--layer5.netlify.app

@ChetanFTW
Copy link
Member Author

Created new PR #6818
can you please check this out

@l5io l5io temporarily deployed to commit September 11, 2025 12:01 Inactive
@l5io l5io temporarily deployed to commit September 11, 2025 12:11 Inactive
@l5io l5io temporarily deployed to commit September 11, 2025 12:24 Inactive
@l5io l5io temporarily deployed to commit September 11, 2025 12:25 Inactive
@l5io l5io temporarily deployed to commit September 11, 2025 17:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants