refactor: enhance modal component structure and styling #6337

Souradip121 · 2025-03-21T19:17:47Z

Description

This PR fixes #6292

Notes for Reviewers

Signed commits

Yes, I signed my commits.

l5io · 2025-03-21T19:36:07Z

🚀 Preview for commit 00a8240 at: https://67ddbf4b017ffe286b34e41d--layer5.netlify.app

l5io · 2025-03-23T16:47:30Z

🚀 Preview for commit 97afb04 at: https://67e03a9684018c4a5a759f22--layer5.netlify.app

vishalvivekm

@Souradip121
please fix failing Eslist checks
https://github.com/layer5io/layer5/actions/runs/14020899270/job/39252725942?pr=6337

Also add it to agenda items for weekly websites meeting [Monday, 24th March | 5:30 PM IST]
meeting minutes.

Souradip121 · 2025-03-23T18:53:14Z

I am facing issues, I have ran using GATSBY_CPU_COUNT=2 make site and over github codespaces with 16GB RAM, with details as follows

Then after running with command GATSBY_CPU_COUNT=2 make site

I really want to contribute, anyone who can help kindly help I have read both blogs
https://discuss.layer5.io/t/problems-with-setting-up-layer5-for-development/6613
https://discuss.layer5.io/t/problems-with-running-local-development-server-for-layer5-development/6780

l5io · 2025-03-24T20:45:02Z

🚀 Preview for commit 3f70933 at: https://67e1c3f417b1b30e64351e3a--layer5.netlify.app

Souradip121 · 2025-03-25T19:58:28Z

I have updated the PR @vishalvivekm you can check

Souradip121 · 2025-03-27T13:47:45Z

I have added the guidance section, also the getting started containing the import statements are as below

l5io · 2025-03-27T13:55:47Z

🚀 Preview for commit eeb4c0c at: https://67e5584754c6b33a415c1750--layer5.netlify.app

vishalvivekm · 2025-03-31T09:17:28Z

@Souradip121
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

l5io · 2025-03-31T09:30:04Z

🚀 Preview for commit afdca78 at: https://67ea6050f55cc03954f740b8--layer5.netlify.app

vishalvivekm · 2025-03-31T09:53:22Z

src/sections/Projects/Sistent/components/modal/code.js

+                  <thead>
+                    <tr>
+                      <th style={{ textAlign: "left", padding: "8px 12px", borderBottom: "2px solid #ddd" }}>Prop</th>
+                      <th style={{ textAlign: "left", padding: "8px 12px", borderBottom: "2px solid #ddd" }}>Type</th>
+                      <th style={{ textAlign: "left", padding: "8px 12px", borderBottom: "2px solid #ddd" }}>Default</th>
+                      <th style={{ textAlign: "left", padding: "8px 12px", borderBottom: "2px solid #ddd" }}>Description</th>
+                    </tr>
+                  </thead>
+                  <tbody>
+                    <tr>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}><code>open</code></td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>boolean</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>false</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>Controls the visibility of the modal</td>
+                    </tr>
+                    <tr>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}><code>closeModal</code></td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>function</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>required</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>Callback function triggered when the modal is closed</td>
+                    </tr>
+                    <tr>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}><code>title</code></td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>string</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>&quot;&quot;</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>Text displayed in the modal header</td>
+                    </tr>
+                    <tr>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}><code>children</code></td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>node</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>required</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>Content to be rendered inside the modal</td>
+                    </tr>
+                    <tr>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}><code>disableBackdropClick</code></td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>boolean</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>false</td>
+                      <td style={{ padding: "8px 12px", borderBottom: "1px solid #ddd" }}>If true, clicking the backdrop will not close the modal</td>


I guess, if we'd be better getting rid of these many repeated inline sytles @Souradip121, thoughts ?

vishalvivekm · 2025-03-31T09:54:22Z

src/sections/Projects/Sistent/components/modal/code.js

+            </a>
+            <div className="showcase">
+              <div className="table-responsive">
+                <table style={{ width: "100%", borderCollapse: "collapse", marginBottom: "20px" }}>


same here and at any number of places in the changes @Souradip121

vishalvivekm

too many inline styles

l5io · 2025-04-01T07:07:34Z

🚀 Preview for commit d17d351 at: https://67eb9074054f9b7bf013f76d--layer5.netlify.app

Signed-off-by: l5io <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: GARY121github <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: l5io <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: vr-varad <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Aditya Raj <[email protected]> This reverts commit 3ea772a. Removed Extra = Appearing Before Email on Lee Calcote’s Bio Page Signed-off-by: Aditya Raj <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: vr-varad <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Souradip Pal <[email protected]>

This reverts commit 439e517. Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: gourav-k-shaw <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: GitHub <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Rian Cteulp <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Aditya Raj <[email protected]> fix: run eslint Signed-off-by: Aditya Raj <[email protected]> Remove unnecessary files Signed-off-by: Aditya Raj <[email protected]> Updated my blog as everyone suggested Signed-off-by: Aditya Raj <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Aditya Raj <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Signed-off-by: Souradip Pal <[email protected]>

github-actions bot added the project/sistent label Mar 21, 2025

Souradip121 force-pushed the master branch from bf033a8 to 00a8240 Compare March 21, 2025 19:22

vishalvivekm requested changes Mar 23, 2025

View reviewed changes

vishalvivekm requested review from amitamrutiya and GARY121github March 27, 2025 13:40

vishalvivekm requested a review from sudhanshutech March 31, 2025 09:51

vishalvivekm reviewed Mar 31, 2025

View reviewed changes

vishalvivekm requested changes Mar 31, 2025

View reviewed changes

github-actions bot added the area/handbook label Apr 1, 2025

MUzairS15 and others added 10 commits April 2, 2025 05:37

[Docs] Generated documentation for Integration

fd7752c

Signed-off-by: l5io <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

fix : highlight active section when switching tabs

458aae0

Signed-off-by: GARY121github <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

refactor: enhance modal component structure and styling

16ac8c7

Signed-off-by: Souradip Pal <[email protected]>

fix: update quote for Guy Menahem in Kanvas section

54eb9ba

Signed-off-by: Lee Calcote <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

[Docs] Generated documentation for Integration

4b79fd2

Signed-off-by: l5io <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

refactor: improve modal guidance content and structure

33aef94

Signed-off-by: Souradip Pal <[email protected]>

style: hide checkboxes by default, show in dark theme toggle

236832b

Signed-off-by: Souradip Pal <[email protected]>

Fixed Readability of Saffron Card

d949a09

Signed-off-by: vr-varad <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Fixed Missing Underline on Guidance Section Click

30d2fec

Signed-off-by: vr-varad <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

vishalvivekm and others added 23 commits April 2, 2025 05:37

rm gradient from common form fields and fix responsive issue

5c69852

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Update commonForm.style.js

1f17bbd

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

extra spaces above pages

ee3d2c0

Signed-off-by: Souradip Pal <[email protected]>

Revert "extra spaces above pages"

ae4bc77

This reverts commit 439e517. Signed-off-by: Souradip Pal <[email protected]>

adding meshery extension details to security vulnerability page

810e462

Signed-off-by: gourav-k-shaw <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Rename meshery-extensions-color.svg to meshery-extensions-color.svg

8ee068a

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Rename meshery-extensions-color.svg to meshery-extensions-color.svg

88eea59

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Update src/sections/Community/Handbook/security-vulnerabilities.js

5e2b202

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

update description

ef3f695

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Update src/sections/Community/Handbook/security-vulnerabilities.js

4ae7fb9

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

[community] feat: add new member profile

524c9b9

Signed-off-by: GitHub <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

replace webhook

d41c269

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Chore: Add Internships email to mail archive

19bab89

Signed-off-by: Rian Cteulp <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

added meshery extension img

2fc813b

Signed-off-by: Aditya Raj <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Delete src/assets/images/meshery/icon-only/meshery-extensions-color.svg

393a0c7

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Apply suggestions from code review

dcf8563

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

rm unused Button

4863ec0

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

rm unused CatalogImage

f798af6

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

rm unused ContactForm

bf2c195

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

rm unused ContactFormModal

7410eba

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

Update src/collections/members/ian-whitney/index.mdx

832decf

Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Souradip Pal <[email protected]>

corrected the inline style

89dfdf2

Signed-off-by: Souradip Pal <[email protected]>

Souradip121 force-pushed the master branch from 9bfcbed to 89dfdf2 Compare April 2, 2025 05:37

github-actions bot added project/meshery area/blog New posts or new blog functionality area/community project/kanvas area/core-styles labels Apr 2, 2025

Souradip121 closed this Apr 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: enhance modal component structure and styling #6337

refactor: enhance modal component structure and styling #6337

Souradip121 commented Mar 21, 2025 •

edited

Loading

l5io commented Mar 21, 2025

l5io commented Mar 23, 2025

vishalvivekm left a comment

Souradip121 commented Mar 23, 2025

l5io commented Mar 24, 2025

Souradip121 commented Mar 25, 2025

Souradip121 commented Mar 27, 2025

l5io commented Mar 27, 2025

vishalvivekm commented Mar 31, 2025

l5io commented Mar 31, 2025

vishalvivekm Mar 31, 2025

vishalvivekm Mar 31, 2025

vishalvivekm left a comment

l5io commented Apr 1, 2025

refactor: enhance modal component structure and styling #6337

refactor: enhance modal component structure and styling #6337

Conversation

Souradip121 commented Mar 21, 2025 • edited Loading

l5io commented Mar 21, 2025

l5io commented Mar 23, 2025

vishalvivekm left a comment

Choose a reason for hiding this comment

Souradip121 commented Mar 23, 2025

l5io commented Mar 24, 2025

Souradip121 commented Mar 25, 2025

Souradip121 commented Mar 27, 2025

l5io commented Mar 27, 2025

vishalvivekm commented Mar 31, 2025

l5io commented Mar 31, 2025

vishalvivekm Mar 31, 2025

Choose a reason for hiding this comment

vishalvivekm Mar 31, 2025

Choose a reason for hiding this comment

vishalvivekm left a comment

Choose a reason for hiding this comment

l5io commented Apr 1, 2025

Souradip121 commented Mar 21, 2025 •

edited

Loading