Skip to content

[Handbook]Fix-6312 Extra spaces in the beginning of handbook pages in layer5 website #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Handbook]Fix-6312 Extra spaces in the beginning of handbook pages in layer5 website #6316

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68b7619
extra spaces above pages
gourav-k-shaw Mar 16, 2025
0d26b17
Revert "extra spaces above pages"
gourav-k-shaw Mar 16, 2025
885e580
removing extra spaces in handbook pages in layer5 website
gourav-k-shaw Mar 16, 2025
c017246
style refactor
gourav-k-shaw Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/sections/Community/Handbook/Handbook.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,21 @@ export const HandbookWrapper = styled.div`
.page-section{
h2{
padding-top: 7rem;
margin-top: -7rem;
padding-top: 0rem;
margin-top: 0rem;
}
h3{
padding-top: 7rem;
margin-top: -7rem;
}
@media (min-width: 750px) {
margin-top: -36rem;
margin-top: -53rem;
margin-left: 20rem;
}
display: flex;
@media screen and (min-width: 768px) and (max-height: 1145px) {
margin-top : -62vh ;
margin-top : -90vh ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't looks good @gourav-k-shaw . It means we are just setting margins as required. In future something around this changes again we have to come and set the margin. Please use some other generic css so and use as less media queries you can. So we don't have to rely on changes around this component.

}
Expand All @@ -62,10 +62,10 @@ export const HandbookWrapper = styled.div`
}
.conduct-section{
@media screen and (min-width: 751px) {
margin-top:-43rem;
margin-top:-90rem;
}
@media screen and (min-width: 768px) and (max-height: 1145px) {
margin-top : -66vh ! important;
margin-top : -90vh ! important;
}
Expand Down
Loading