feat: Implement heading permalinks with hover chain icon #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
added meshery extension org help wanted issues to label
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Create contributing video guide
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: Discuss bot <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: Discuss bot <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
rm meshery from home pages of /cloud, /kanvas
Signed-off-by: mahadevan <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
…rom-cloud-docs fix: remove references
Signed-off-by: Discuss bot <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: l5io <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: favourTy <[email protected]>
FavourTy
force-pushed
the
feature/heading-permalinks
branch
from
1f734b2 to
5917ec6
Compare
|
Oh, interesting - a render hook. I was expecting a pseudo selector for ::after with Unicode for a link icon. With the said, the render hook not only inserts the link icon, but also an anchor element. Nice. Please be sure to use the existing variable for color, not the literal hex code itself. Double check that your use of Keppel green (#00b39f) is an alignment with what I think might be largely the use of the Caribbean green as the action color / |
zihanKuang
requested changes
Jun 7, 2025
There was a problem hiding this comment.
Hi @FavourTy , this is excellent work! I just have a couple of minor suggestions😊:
- The image on the homepage has shifted. There might be an issue with the settings for the text formatting.
- I think it would look more consistent if the icons at all levels were slightly smaller. For reference, you can see in the Meshery documentation that the icons are about the same size as the text, but in the Layer5 documentation, they are a bit larger.
- This is from the Layer5 documentation.
- This is from the Meshery documentation.
|
Hey @FavourTy, our repository ran into some issues recently, which unfortunately led to us having to close all open PRs.🤕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits