feat: Implement the LDAIClient and LDAITracker classes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
requested changes
Jun 10, 2025
| @@ -0,0 +1,3 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require_relative 'ldclient-ai' | |||
There was a problem hiding this comment.
I don't think you need this file and the `lib/ldclient-ai.rb' file.
There was a problem hiding this comment.
I was following this recommendation from: https://guides.rubygems.org/make-your-own-gem/
Code for your package is placed within the lib directory. The convention is to have one Ruby file with the same name as your gem, since that gets loaded when require "hola" is run. That one file is in charge of setting up your gem’s code and API.
It appears we also do this in https://github.com/launchdarkly/ruby-server-sdk/tree/main/lib to support autoloading via bundler.require.
- Add role validation to LDMessage class with VALID_ROLES constant - Improve nil safety in track_tokens method using safe navigation operator - Remove TODO comment by implementing proper role validation - Add type checking for TokenUsage parameter in track_tokens method Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.