Case-insensitive ZIP loading #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotHyper-474
changed the title
NotHyper-474
force-pushed
the
insens-zip-parsing
branch
2 times, most recently
from
e9d6862 to
c494606
Compare
NotHyper-474
force-pushed
the
insens-zip-parsing
branch
from
c494606 to
ca4205c
Compare
NotHyper-474
force-pushed
the
insens-zip-parsing
branch
3 times, most recently
from
289085b to
e49dfb9
Compare
|
This code seems good but I wonder if the behavior could be made optional (via a compilation flag or similar) since some applications may expect case-sensitive asset loading. Or maybe we could do the opposite and ensure case-sensitive asset loading on Windows. |
|
Done. Now you need to set a
Definitely would break a mod or two (I know for sure QT: Rewired would be among these as it has a couple of vocals that don't load on Linux). Personally I'm more inclined towards ensuring case-insensitive loading on Linux instead, but up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mod shows an interesting problem that is, the modder might not care enough for the letter case of the files, which may cause inconsistent behavior (files not loading) not only in case-sensitive platforms (like Linux) but also when trying to load their mod as a ZIP.
This PR aims to solve at least the ZIP part. I might look into the Linux issue later.