-
Notifications
You must be signed in to change notification settings - Fork 73
Case-insensitive ZIP loading #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: experimental
Are you sure you want to change the base?
Case-insensitive ZIP loading #204
Conversation
e9d6862
to
c494606
Compare
c494606
to
ca4205c
Compare
289085b
to
e49dfb9
Compare
This code seems good but I wonder if the behavior could be made optional (via a compilation flag or similar) since some applications may expect case-sensitive asset loading. Or maybe we could do the opposite and ensure case-sensitive asset loading on Windows. |
Done. Now you need to set a
Definitely would break a mod or two (I know for sure QT: Rewired would be among these as it has a couple of vocals that don't load on Linux). Personally I'm more inclined towards ensuring case-insensitive loading on Linux instead, but up to you. |
81ad4de
to
365fec8
Compare
365fec8
to
ebbfda8
Compare
ebbfda8
to
d92519b
Compare
d92519b
to
0a2ec28
Compare
This mod shows an interesting problem that is, the modder might not care enough for the letter case of the files, which may cause inconsistent behavior (files not loading) not only in case-sensitive platforms (like Linux) but also when trying to load their mod as a ZIP.
This PR aims to solve at least the ZIP part. I might look into the Linux issue later.