[FEATURE] Add a way to download dependencies #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemz1
force-pushed
the
feature/download-dependency
branch
from
776c3ee to
d06654d
Compare
|
Is there anything preventing this from being used to download a virus? Sounds like a security concern. |
|
To be fair any mod that you would download is a security concern. The security measures should be handled by the developer that wants to add automatic dependency downloading for their game. For example, the developer could make a popup appear that asks for permission to download not found dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
This pr adds functions to download the dependency using a github repo and commit hash. You can also just get the bytes of the generated zip, so that you can handle downloading it yourself.