Skip to content

Conversation

@crynobone
Copy link
Member

@crynobone crynobone commented Nov 20, 2025

  • Redis PHP extension
  • Memcached PHP extension

crynobone and others added 15 commits November 20, 2025 09:08
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone marked this pull request as ready for review November 20, 2025 03:36
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@browner12
Copy link
Contributor

would it make more sense to use something like version_compare(PHP_VERSION, '8.4.0', '>=') to more consistent with other version checking in the FW? this would be the first use of the PHP_VERSION_ID constant in the codebase.

@crynobone crynobone marked this pull request as draft November 20, 2025 07:28
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
Copy link
Member Author

crynobone commented Nov 20, 2025

@browner12 The constant is temporarily used until symfony/polyfill#549 gets merged.

We hope it will be available before PHP 8.5.0 stable release is available but we need to prepare all our 1st party packages right now.

@crynobone crynobone marked this pull request as ready for review November 20, 2025 08:39
@browner12
Copy link
Contributor

yah, I wasn't suggesting not checking the version. I was just suggesting to stay consistent with other version checking in the FW and switch:

PHP_VERSION_ID >= 80500;

to

version_compare(phpversion(), '8.5.0', '>=');

if you don't expect this code to stay in long, I guess I'm indifferent, but if it'll be in there a bit would be nice to stay consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants