fix: Fix demo banner layout conflict with sidebar #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract demo banner from global fixed positioning to prevent sidebar overlap - Create reusable DemoBanner component with proper positioning logic - Consolidate header structure across all app pages using new Header component - Remove duplicate header code from agents, inbox, chat, rag, tools, and playground pages - Fix visual bug where demo banner was being cut off by the sidebar layout Resolves layout conflict where the fixed-positioned demo banner would overlap or be clipped by the sidebar navigation structure.
|
@christian-bromann is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
bracesproul
requested changes
Jun 26, 2025
There was a problem hiding this comment.
Sorry for the delay on reviewing. I like refactoring it out into its own reusable component, however the implementation you pushed means the sidebar covers up part of the UI (breadcrumbs, and OAP logo in sidebar).
If you still want to work on this PR I would request one of two things:
- keep the old styling, but use your refactor
- update the styling to instead shift everything down, and have the header be above every UI element (also keep your refactor)
Thanks
|
@bracesproul thanks for the review, I'll try to get back to this asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The demo banner was positioned with
fixed top-0 right-0 left-0at the global layout level, which caused it to overlap or be clipped by the sidebar navigation. This created a visual bug where the banner would not display properly within the sidebar layout structure.Solution
DemoBannercomponentHeadercomponent to consolidate header structure across all app pagesChanges Made
DemoBannercomponent inapps/web/src/components/ui/demo.tsxHeadercomponentHeadercomponent:/agents/page.tsx/inbox/page.tsx/page.tsx(chat)/rag/page.tsx/tools/page.tsx/tools/playground/page.tsxapps/web/src/app/(app)/layout.tsx)Benefits
Testing
Note: I don't have access to Supabase and couldn't run the app without it, please verify visual accuracy.
Type of Change