fix: update ConfluenceLoader to use the rest/api/search API endpoint which supports the includeArchivedSpaces parameter #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which supports the includeArchivedSpaces parameter
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| pages = [] | ||
| for item in results: | ||
| # return the content field of each result object | ||
| pages.append(item["content"]) |
There was a problem hiding this comment.
KeyError vulnerability: The code assumes every result item has a 'content' field without validation. If the API returns results without this field, the code will crash with a KeyError. Add a safety check: if 'content' in item: pages.append(item['content']) or use item.get('content') with appropriate handling for missing content.
Suggested change
| pages.append(item["content"]) | |
| if "content" in item: | |
| pages.append(item["content"]) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ConfluenceLoader to use the other cql search api which actually supports the Parameter
includeArchivedSpacesandfixes #328
I am not very sure if the switch to that other search api breaks or slows down the code, but in my use case it looks fine so far.