fix(chroma): cap hnsw:num_threads to available CPU cores during collection load Closes langchain-ai/langchain#32678 #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a guard in the Chroma vectorstore implementation to ensure that the
hnsw:num_threads
metadata parameter does not exceed the number of available CPU cores when loading a persisted collection.Context
Fixes a bug where moving a Chroma collection from a server with N CPU cores to one with fewer cores (M < N) could cause a
ValueError
ifhnsw:num_threads
was set higher than supported on the new host. See: langchain-ai/langchain#32678Changes
langchain_community/vectorstores/chroma.py
, thread allocation in collection metadata is capped toos.cpu_count()
if necessary during init.tests/unit_tests/vectorstores/test_chroma.py
:Testing
Closes langchain-ai/langchain#32678