remote/coordinator: drop returns from finally clauses #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions in finally clauses containing return statements are swallowed [1]. That means any exception raised in the try block and a subsequent KeyError in the finally block leads to the original exception being swallowed. Since Python 3.14 "the compiler emits a SyntaxWarning when a return, break or continue appears in a finally block (see PEP 765)." [2]. Fix this by moving the code relying on the session into the try clause making the return in the except clause obsolete. [1] https://peps.python.org/pep-0765/#motivation [2] https://docs.python.org/3.14/reference/compound_stmts.html#finally-clause Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added
fix
pick to stable
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1722 +/- ##
======================================
Coverage 55.6% 55.6%
======================================
Files 172 172
Lines 13495 13493 -2
======================================
Hits 7514 7514
+ Misses 5981 5979 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exceptions in finally clauses containing return statements are swallowed [1]. That means any exception raised in the try block and a subsequent KeyError in the finally block leads to the original exception being swallowed.
Since Python 3.14 "the compiler emits a SyntaxWarning when a return, break or continue appears in a finally block (see PEP 765)." [2].
Fix this by moving the code relying on the session into the try clause making the return in the except clause obsolete.
[1] https://peps.python.org/pep-0765/#motivation
[2] https://docs.python.org/3.14/reference/compound_stmts.html#finally-clause
Checklist
Fixes #1469