forked from expressjs/expressjs.com
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] gh-pages from expressjs:gh-pages #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
396
commits into
labaran1:gh-pages
Choose a base branch
from
expressjs:gh-pages
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb4652e
to
726bf05
Compare
297cae3
to
cf49d9b
Compare
* Remove outdated info and broken links * Update consolidate package name
New Crowdin translations by GitHub Action Co-authored-by: Crowdin Bot <[email protected]>
Co-authored-by: Linus Unnebäck <[email protected]> Co-authored-by: Chris de Almeida <[email protected]> Co-authored-by: Jon Church <[email protected]>
It works by cancelling the onclick URL change for the current (bold) parent menu item. This matches the mobile experience. Touchscreens can now tap a menu to go there (preserving current UX), tap again to open the submenu, then tap the submenu item. Previous behavior with mice is unchanged. Co-authored-by: ShubhamOulkar <[email protected]> Co-authored-by: bjohansebas <[email protected]>
Co-authored-by: bjohansebas <[email protected]> Co-authored-by: ShubhamOulkar <[email protected]>
…ng to ignore (#1987) (#1989) Co-authored-by: bjohansebas <[email protected]>
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.245.0 to 1.254.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@a4effe4...2a7b300) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.254.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bjohansebas <[email protected]>
Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 2.8.0 to 2.9.1. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@297234b...590c05e) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.9.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bjohansebas <[email protected]>
docker: match GH page ruby version, 3.3.4
* add scroll-to-top and scroll class toggle with vanilla JS * add language detection * add i18n * Fix bug: there was no class hidden in CSS. Notice was hidden by hide(). Now HTML hidden attribute is used to hide notice using CSS. This improves A11y. * fix flashing of i18n notice and improve a11y * add menu highlighting on scroll * ♻️ remove jquery * defer app.js Co-authored-by: Sebastian Beltran <[email protected]> * remove DOMContentLoaded and fix root margin to 25% --------- Co-authored-by: bjohansebas <[email protected]>
remove seo results
Signed-off-by: Sebastian Beltran <[email protected]> Co-authored-by: shubham oulkar <[email protected]>
…site (#1965) * feat(#1932): implement smooth scrolling for anchor navigation across site * feat: implement CSS-only smooth scrolling for anchor navigation * apply reviewer changes: Update scroll-margin-top to 60px and remove preventDefault for TOC links * remove scroll to top functionality and prevent default navigation for submenu links Signed-off-by: Sebastian Beltran <[email protected]> --------- Co-authored-by: ShubhamOulkar <[email protected]> Co-authored-by: bjohansebas <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
* ci: fix multiple comments in Lighthouse workflow Signed-off-by: Sebastian Beltran <[email protected]> * fix comment --------- Signed-off-by: Sebastian Beltran <[email protected]> Co-authored-by: shubham oulkar <[email protected]>
This option was also not documented. It was added as part of a fix for a vulnerability (see GHSA-qwcr-r2fm-qrc7). ref: expressjs/express#5926, expressjs/body-parser@afd0f39 --------- Signed-off-by: Sebastian Beltran <[email protected]> Co-authored-by: UlisesGascon <[email protected]>
New Crowdin translations from the [express.js crowdin project](https://express.crowdin.com/u/projects/1). Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: bjohansebas <[email protected]>
…2000) Improve the message by expanding on how the cookie is cleared, and include a note about the deprecation of the `max-age` and `expires` options: in Express 4 they are still respected (not ignored), whereas in Express 5 they are ignored. ref: expressjs/express#5792 ref: expressjs/express#5640 ref: expressjs/express#5672 closes: #1146 Note: We need to manage changes more effectively. Whenever there are changes, and once they have been released, a PR should be opened here to update the documentation. Improving these processes will help us keep our documentation better maintained. Signed-off-by: Sebastian Beltran <[email protected]> Co-authored-by: ShubhamOulkar <[email protected]>
Co-authored-by: bjohansebas <[email protected]>
Co-authored-by: Sebastian Beltran <[email protected]>
Co-authored-by: Crowdin Bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )