Loosen numpy, huggingface-hub, other dependency requirements #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo check,cargo clippy,cargo test.PR Description
I was having trouble resolving dependencies for
numpyandhuggingface-hub. This pull request loosens the dependency versions for those packages. It also removes the maximum dependency version for other packages (let me know if you'd like me to revert the others – they haven't caused me trouble directly, but looser dependencies may be helpful for others). I ran inference with these changes and everything seems to be working correctly.I'm not sure how to run the pre-commit hook – does it run automatically when I open the pull request?
I, samuelbradshaw, confirm that I have read and understood the terms of the CLA of Kyutai-labs, as outlined in the repository's CONTRIBUTING.md, and I agree to be bound by these terms.