Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@Jasonlmx
Copy link
Contributor

Support more list functions:

-List_consine _similarity(list1, list2)

@Jasonlmx Jasonlmx force-pushed the add-list-functions branch 2 times, most recently from 5f8886a to 3010cc0 Compare September 16, 2025 14:05
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.24%. Comparing base (d33be14) to head (3010cc0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/function/list/list_cosine_similarity.cpp 9.09% 50 Missing ⚠️

❌ Your patch check has failed because the patch coverage (9.09%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6014      +/-   ##
==========================================
- Coverage   86.31%   86.24%   -0.07%     
==========================================
  Files        1456     1457       +1     
  Lines       65856    65911      +55     
  Branches     8037     8037              
==========================================
+ Hits        56841    56845       +4     
- Misses       8756     8808      +52     
+ Partials      259      258       -1     
Flag Coverage Δ
in-mem 80.95% <9.09%> (-0.07%) ⬇️
on-disk 86.32% <9.09%> (-0.07%) ⬇️
recovery 86.32% <9.09%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jasonlmx Jasonlmx force-pushed the add-list-functions branch 4 times, most recently from 893a7b9 to 9abb0f8 Compare September 16, 2025 19:07
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Benchmark Result

Master commit hash: 1c3fa86da43eeeb471abaab6751ea8583ebaed90
Branch commit hash: 4ca2fae12a8c5821adcb55ea3421b0a7e03b7e05

No major diffs!

Other queries
Query Group Query Name Mean Time - Commit (ms)
aggregation q24 709.14
aggregation q28 7777.09
filter q14 62.37
filter q15 61.61
filter q16 274.83
filter q17 386.43
filter q18 1854.28
filter zonemap-node 27.96
filter zonemap-node-lhs-cast 28.34
filter zonemap-node-null 28.07
filter zonemap-rel 5106.81
fixed_size_expr_evaluator q07 623.84
fixed_size_expr_evaluator q08 909.45
fixed_size_expr_evaluator q09 908.98
fixed_size_expr_evaluator q10 197.73
fixed_size_expr_evaluator q11 196.10
fixed_size_expr_evaluator q12 175.76
fixed_size_expr_evaluator q13 1506.10
fixed_size_seq_scan q23 61.78
join q29 769.15
join q30 1664.91
join q31 6.83
join SelectiveTwoHopJoin 45.17
ldbc_snb_ic q35 13.75
ldbc_snb_ic q36 95.85
ldbc_snb_is q32 3.03
ldbc_snb_is q33 8.08
ldbc_snb_is q34 2.81
limit push-down-limit-into-distinct 2023.25
multi-rel multi-rel-large-scan 1618.72
multi-rel multi-rel-lookup 10.63
multi-rel multi-rel-small-scan 206.73
order_by q25 67.12
order_by q26 395.15
order_by q27 1310.60
recursive_join recursive-join-bidirection 367.65
recursive_join recursive-join-dense 6952.61
recursive_join recursive-join-path 23580.76
recursive_join recursive-join-sparse 7.10
recursive_join recursive-join-trail 6923.53
scan_after_filter q01 109.40
scan_after_filter q02 95.90
shortest_path_ldbc100 q37 224.72
shortest_path_ldbc100 q38 337.25
shortest_path_ldbc100 q39 76.26
shortest_path_ldbc100 q40 527.21
var_size_expr_evaluator q03 2108.03
var_size_expr_evaluator q04 2141.43
var_size_expr_evaluator q05 2615.45
var_size_expr_evaluator q06 1274.89
var_size_seq_scan q19 1369.24
var_size_seq_scan q20 2197.80
var_size_seq_scan q21 2119.11
var_size_seq_scan q22 111.08

@Jasonlmx Jasonlmx force-pushed the add-list-functions branch 2 times, most recently from f0ff3c6 to 70abac0 Compare September 19, 2025 20:31
@Jasonlmx Jasonlmx force-pushed the add-list-functions branch 2 times, most recently from 930b6af to 0071140 Compare September 26, 2025 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant