Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@tgahunia05
Copy link
Contributor

Description

Please include a summary of the changes and the related issue (if applicable).
Please also include relevant motivation and context.

Fixes #(issue)
Associated docs (issue or PR):

Contributor agreement

@tgahunia05 tgahunia05 self-assigned this Aug 15, 2025
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 89.29889% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.88%. Comparing base (cd56340) to head (98ec42b).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...nsion/algo/src/function/betweenness_centrality.cpp 88.97% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5888      +/-   ##
==========================================
- Coverage   86.35%   85.88%   -0.48%     
==========================================
  Files        1444     1632     +188     
  Lines       64811    74986   +10175     
  Branches     7925     8933    +1008     
==========================================
+ Hits        55970    64404    +8434     
- Misses       8607    10346    +1739     
- Partials      234      236       +2     
Flag Coverage Δ
extension 64.17% <89.29%> (?)
in-mem 81.38% <0.00%> (+0.02%) ⬆️
on-disk 86.42% <0.00%> (+<0.01%) ⬆️
recovery 86.42% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Aug 15, 2025

Benchmark Result

Master commit hash: 81328e0359de92960a3b8e3af1c93b00b3261070
Branch commit hash: ac7edc6da13151d8bdb7aba53e70168720a14e87

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
multi-rel multi-rel-large-scan 1877.96 1468.89 409.07 (27.85%)
multi-rel multi-rel-lookup 10.04 6.51 3.53 (54.28%)
recursive_join recursive-join-dense 7084.48 5710.70 1373.78 (24.06%)
recursive_join recursive-join-sparse 9.91 7.90 2.01 (25.47%)
Other queries
Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 716.34 697.69 18.65 (2.67%)
aggregation q28 7739.45 7722.90 16.56 (0.21%)
copy node-Comment 81044.52 N/A N/A
copy node-Forum 5643.86 N/A N/A
copy node-Organisation 1271.11 N/A N/A
copy node-Person 1992.70 N/A N/A
copy node-Place 1168.36 N/A N/A
copy node-Post 34758.37 N/A N/A
copy node-Tag 1186.63 N/A N/A
copy node-Tagclass 1145.26 N/A N/A
copy rel-comment-hasCreator 55816.12 N/A N/A
copy rel-comment-hasTag 78583.89 N/A N/A
copy rel-comment-isLocatedIn 61986.16 N/A N/A
copy rel-containerOf 14999.84 N/A N/A
copy rel-forum-hasTag 3669.23 N/A N/A
copy rel-hasInterest 2776.15 N/A N/A
copy rel-hasMember 53715.06 N/A N/A
copy rel-hasModerator 1417.18 N/A N/A
copy rel-hasType 234.11 N/A N/A
copy rel-isPartOf 221.74 N/A N/A
copy rel-isSubclassOf 227.42 N/A N/A
copy rel-knows 6589.79 N/A N/A
copy rel-likes-comment 89678.23 N/A N/A
copy rel-likes-post 35958.83 N/A N/A
copy rel-organisation-isLocatedIn 278.57 N/A N/A
copy rel-person-isLocatedIn 429.39 N/A N/A
copy rel-post-hasCreator 15050.61 N/A N/A
copy rel-post-hasTag 20612.28 N/A N/A
copy rel-post-isLocatedIn 16523.28 N/A N/A
copy rel-replyOf-comment 52795.10 N/A N/A
copy rel-replyOf-post 41422.03 N/A N/A
copy rel-studyAt 510.64 N/A N/A
copy rel-workAt 700.94 N/A N/A
filter q14 59.61 59.80 -0.19 (-0.32%)
filter q15 64.73 57.91 6.83 (11.79%)
filter q16 276.51 276.87 -0.35 (-0.13%)
filter q17 385.09 386.07 -0.97 (-0.25%)
filter q18 1853.63 1858.36 -4.72 (-0.25%)
filter zonemap-node 23.51 23.48 0.03 (0.14%)
filter zonemap-node-lhs-cast 23.84 23.82 0.02 (0.09%)
filter zonemap-node-null 23.51 23.51 0.00 (0.01%)
filter zonemap-rel 5578.66 5691.53 -112.87 (-1.98%)
fixed_size_expr_evaluator q07 632.47 635.51 -3.03 (-0.48%)
fixed_size_expr_evaluator q08 923.82 917.22 6.60 (0.72%)
fixed_size_expr_evaluator q09 921.01 923.95 -2.94 (-0.32%)
fixed_size_expr_evaluator q10 194.08 200.36 -6.27 (-3.13%)
fixed_size_expr_evaluator q11 193.37 199.60 -6.23 (-3.12%)
fixed_size_expr_evaluator q12 172.24 177.40 -5.16 (-2.91%)
fixed_size_expr_evaluator q13 1559.08 1503.55 55.53 (3.69%)
fixed_size_seq_scan q23 45.92 54.15 -8.23 (-15.19%)
join q29 763.45 812.15 -48.71 (-6.00%)
join q30 1753.07 1774.11 -21.03 (-1.19%)
join q31 5.98 5.23 0.75 (14.24%)
join SelectiveTwoHopJoin 51.33 43.63 7.70 (17.64%)
ldbc_snb_ic q35 9.98 9.41 0.57 (6.05%)
ldbc_snb_ic q36 102.15 99.89 2.26 (2.27%)
ldbc_snb_is q32 4.13 4.38 -0.25 (-5.72%)
ldbc_snb_is q33 13.01 11.34 1.66 (14.67%)
ldbc_snb_is q34 1.23 1.32 -0.09 (-6.82%)
limit push-down-limit-into-distinct 1950.08 1993.38 -43.29 (-2.17%)
multi-rel multi-rel-small-scan 177.54 180.18 -2.65 (-1.47%)
order_by q25 62.75 65.28 -2.54 (-3.89%)
order_by q26 398.28 382.97 15.31 (4.00%)
order_by q27 1318.43 1327.15 -8.72 (-0.66%)
recursive_join recursive-join-bidirection 325.16 273.77 51.40 (18.77%)
recursive_join recursive-join-path 23607.36 22936.12 671.24 (2.93%)
recursive_join recursive-join-trail 7046.49 6025.30 1021.19 (16.95%)
scan_after_filter q01 102.58 100.45 2.13 (2.12%)
scan_after_filter q02 91.41 90.11 1.30 (1.44%)
shortest_path_ldbc100 q37 76.92 77.71 -0.79 (-1.02%)
shortest_path_ldbc100 q38 336.78 322.89 13.88 (4.30%)
shortest_path_ldbc100 q39 82.13 84.35 -2.22 (-2.63%)
shortest_path_ldbc100 q40 511.50 497.27 14.22 (2.86%)
var_size_expr_evaluator q03 2119.29 2128.91 -9.62 (-0.45%)
var_size_expr_evaluator q04 2132.21 2174.38 -42.17 (-1.94%)
var_size_expr_evaluator q05 2621.20 2694.62 -73.42 (-2.72%)
var_size_expr_evaluator q06 1281.21 1284.70 -3.48 (-0.27%)
var_size_seq_scan q19 1355.44 1355.62 -0.18 (-0.01%)
var_size_seq_scan q20 2654.44 2681.67 -27.23 (-1.02%)
var_size_seq_scan q21 2182.18 2180.72 1.47 (0.07%)
var_size_seq_scan q22 110.19 111.53 -1.35 (-1.21%)

@tgahunia05 tgahunia05 force-pushed the algo-betweenness-centrality branch 2 times, most recently from bdc8bc0 to bc82640 Compare August 19, 2025 12:15
@tgahunia05 tgahunia05 force-pushed the algo-betweenness-centrality branch from 235a206 to cfa1f72 Compare August 21, 2025 12:38
@tgahunia05
Copy link
Contributor Author

This implementation is not matching with Neo4j or NetworkX on large graphs. These differences need to be resolved before merging. Additionally there are some TODO items I have left in which could slightly improve performance. They should be tried (or at least considered).

Note that this does not include the sampling interface. Full compute should be validated with other engines and implementations before sampling related work is done.

@ray6080 ray6080 assigned andyfengHKU and unassigned tgahunia05 Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants