Skip to content

id: Add za in as owners and reviewers in sig-docs-id #50761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

za
Copy link
Contributor

@za za commented May 2, 2025

so za can start reviewing and merging PR for sig-docs-id PRs.

Related PR on org:
kubernetes/org#5489

so za can start reviewing and merging PR for sig-docs-id PRs.

Related PR on org:
kubernetes/org#5489
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from lmktfy May 2, 2025 02:30
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2025
Copy link

netlify bot commented May 2, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 26d53e7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/68142e3ebc05d300088d08ec
😎 Deploy Preview https://deploy-preview-50761--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@divya-mohan0209
Copy link
Contributor

@girikuncoro @ariscahyadi @habibrosyad : Please confirm on this PR if we can add @za to the Indonesian owners and reviewers list?

@girikuncoro
Copy link
Contributor

@divya-mohan0209 yes we need @za to help speed up the reviews/approval processes and he's been the one who helped reviving the project and driving the recent contributions, thank you for taking a look at this PR

@ariscahyadi
Copy link
Contributor

Hi @divya-mohan0209.. agreed with @girikuncoro, recently @za made a lot of contribution of reviewing the translation PR.

Copy link
Contributor

@ariscahyadi ariscahyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @za

@za
Copy link
Contributor Author

za commented May 2, 2025

Thanks @girikuncoro and @ariscahyadi

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your responses!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a69464e7963d391b7e93640575a413002f8cb5f3

@lmktfy
Copy link
Contributor

lmktfy commented May 5, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 43821c0 into kubernetes:main May 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants