-
Notifications
You must be signed in to change notification settings - Fork 792
Add tomasaschan to kdp maintainers #5563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justinsb, tomasaschan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
cc: @kubernetes/sig-api-machinery-leads for approve |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
It makes me sad that stuff like this doesn't get attention. Not only because this is about me specifically, but the wording here is so ironic - the bot starts by explaining that k8s doesn't have enough contributors, but resolving this (which seems to me like it should be a very quick review) is literally a way to help mitigate that very problem. |
/remove-lifecycle stale Ping @kubernetes/sig-api-machinery-leads |
This comment has been minimized.
This comment has been minimized.
@tomasaschan: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This comment has been minimized.
This comment has been minimized.
@tomasaschan: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @mrbobbytables - did I do something wrong when I opened the PR? Like @tomasaschan I am surprised that this did not effectively merge-on-green |
To support kubernetes-sigs/kubebuilder-declarative-pattern#417 and similar
tomasaschan is already in OWNERS as an approver