Skip to content

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Apr 25, 2025

To support kubernetes-sigs/kubebuilder-declarative-pattern#417 and similar

tomasaschan is already in OWNERS as an approver

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Apr 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz April 25, 2025 14:25
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sttts April 25, 2025 14:25
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinsb, tomasaschan
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tomasaschan
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2025
@Priyankasaggu11929
Copy link
Member

cc: @kubernetes/sig-api-machinery-leads for approve

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025
@tomasaschan
Copy link
Member

It makes me sad that stuff like this doesn't get attention. Not only because this is about me specifically, but the wording here is so ironic - the bot starts by explaining that k8s doesn't have enough contributors, but resolving this (which seems to me like it should be a very quick review) is literally a way to help mitigate that very problem.

@tomasaschan
Copy link
Member

tomasaschan commented Sep 15, 2025

/remove-lifecycle stale

Ping @kubernetes/sig-api-machinery-leads

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 15, 2025
@tomasaschan

This comment has been minimized.

@k8s-ci-robot
Copy link
Contributor

@tomasaschan: The label(s) /remove-label kind/api-change cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label kind/api-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tomasaschan

This comment has been minimized.

@k8s-ci-robot
Copy link
Contributor

@tomasaschan: Those labels are not set on the issue: api-review

In response to this:

/remove-label api-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@justinsb
Copy link
Member Author

Hey @mrbobbytables - did I do something wrong when I opened the PR? Like @tomasaschan I am surprised that this did not effectively merge-on-green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants