-
Notifications
You must be signed in to change notification settings - Fork 40.6k
Fix typo in the --anonymous-auth
flag name
#131980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @LucaBernstein! |
Hi @LucaBernstein. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test @LucaBernstein Thanks for your contribution. This error message change may be an API change. If it is, there are several requirements to merge it, including deprecating the error message across multiple releases. Please check with SIG API Machinery to determine if this requires the full flag API change mechanism. Thanks :) |
I am not quite sure this indeed classifies as API change. There is no value doing deprecations in this particular case. How would you do this at all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d70da8ddbfa1870cce25323c7ff1d076326a39ec
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ialidzhikov, LucaBernstein The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-unit |
/cc @dims |
/cc @liggitt |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix a typo in an error message during apiserver authentication.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: