Skip to content

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 7, 2025

Invoke the helm-values-schema-json Helm plugin directly as a go tool instead as a helm plugin command. Simplifies dependency management and makes sure that users always have the tool available without manually installing anything in their system.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@marquiz
Copy link
Contributor Author

marquiz commented Oct 7, 2025

/assign @fmuyassarov

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 7, 2025
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 0005b5f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/68e4e4827a637200089713a8
😎 Deploy Preview https://deploy-preview-2326--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Invoke the helm-values-schema-json Helm plugin directly as a go tool
instead as a helm plugin command. Simplifies dependency management and
makes sure that users always have the tool available without manually
installing anything in their system.
@marquiz marquiz force-pushed the devel/go-tools-helm-schema branch from 06ba13a to 0005b5f Compare October 7, 2025 09:59
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df9b234823a2328bf4155cd7a9bef12568f613e8

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 42eeb21 into kubernetes-sigs:master Oct 7, 2025
10 checks passed
@marquiz marquiz deleted the devel/go-tools-helm-schema branch October 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants