Skip to content

Conversation

@panpan0000
Copy link
Contributor

@panpan0000 panpan0000 commented Jun 3, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it


NOTE: this is another implementation of PR #540

say, we have two LWS instance on the same nodes,
LWS-1 requires CPU
LWS-2 requires GPU
they should share the same topology , and the exclusive policy should apply inside LWS-1 and LWS-2 respectively.

But now, if LWS-1 occupied the nodes, the LWS-2 will be pending

Which issue(s) this PR fixes

Fixes #539

Special notes for your reviewer

assuming LWS name: A, replicas=2, size=2
our expectation is : Pod A-0-x should have anti-affinity with those Pods A-1-x,
but can co-locate with other LWS like B-0-x
also can co-locate with same LWS name in other NS, like A-0-x in namespace 2.

so The anti-affinity condition should be:

  • (1)same namespace
  • (2) same LWS set name
  • (3) different group/replica ID

Does this PR introduce a user-facing change?


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2025
@netlify
Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for kubernetes-sigs-lws ready!

Name Link
🔨 Latest commit 2471ae8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-lws/deploys/683ea770979d55000889f766
😎 Deploy Preview https://deploy-preview-551--kubernetes-sigs-lws.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: panpan0000
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @panpan0000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2025
@panpan0000 panpan0000 closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exclusive-topology antiAffinity should include matching LWS name

2 participants