fix: exclusive topology only affect inside LWS instance #551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
NOTE: this is another implementation of PR #540
say, we have two LWS instance on the same nodes,
LWS-1 requires CPU
LWS-2 requires GPU
they should share the same topology , and the exclusive policy should apply inside LWS-1 and LWS-2 respectively.
But now, if LWS-1 occupied the nodes, the LWS-2 will be pending
Which issue(s) this PR fixes
Fixes #539
Special notes for your reviewer
assuming LWS name: A, replicas=2, size=2
our expectation is : Pod
A-0-xshould have anti-affinity with those PodsA-1-x,but can co-locate with other LWS like
B-0-xalso can co-locate with same LWS name in other NS, like
A-0-xin namespace 2.so The anti-affinity condition should be:
Does this PR introduce a user-facing change?