Propogate user defined labels on the RGI to resources #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arsh Sharma <[email protected]>
Signed-off-by: Arsh Sharma <[email protected]>
|
@a-hilaly I wasn't able to figure out where to write the tests for this, can you please point me in the right direction? |
Signed-off-by: Arsh Sharma <[email protected]>
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
a-hilaly
reviewed
Sep 15, 2025
| igr.log.V(1).Info("Creating new resource", "resourceID", resourceID) | ||
|
|
||
| // Check if label propagation is enabled | ||
| annotations, found := igr.runtime.GetInstance().Object["metadata"].(map[string]interface{})["annotations"].(map[string]interface{}) |
There was a problem hiding this comment.
Suggested change
| annotations, found := igr.runtime.GetInstance().Object["metadata"].(map[string]interface{})["annotations"].(map[string]interface{}) | |
| annotations := igr.runtime.GetInstance().GetAnnotations() |
|
|
||
| func (igr *instanceGraphReconciler) propagateLabelsToResource(resource *unstructured.Unstructured) { | ||
| // Get labels from the RGI | ||
| rgiLabels, found := igr.runtime.GetInstance().Object["metadata"].(map[string]interface{})["labels"].(map[string]interface{}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to propogate the labels they have set on the Resource Group Instance by using setting the
kro.run/propagate-labels: "true"annotation.Fixes #184
Sample RGI to try it out with:
Use the RG from the getting started guide with this.